Copilot commented on code in PR #7867: URL: https://github.com/apache/incubator-seata/pull/7867#discussion_r2633559227
########## integration-tx-api/src/test/java/org/apache/seata/integration/tx/api/interceptor/parser/NonPrivateMethodTestClass.java: ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.seata.integration.tx.api.interceptor.parser; + +import org.apache.seata.spring.annotation.GlobalTransactional; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class NonPrivateMethodTestClass { + private static final Logger LOGGER = LoggerFactory.getLogger(NonPrivateMethodTestClass.class); + + @GlobalTransactional(timeoutMills = 300000) + String dftMethod() { Review Comment: The method name `dftMethod` uses an unclear abbreviation. Consider renaming to `defaultMethod` or `packagePrivateMethod` to better communicate that this method has package-private (default) access visibility. This would make the test class more self-documenting and easier to understand. ```suggestion String defaultMethod() { ``` ########## integration-tx-api/src/test/java/org/apache/seata/integration/tx/api/interceptor/parser/GlobalTransactionalInterceptorParserTest.java: ########## @@ -38,4 +38,19 @@ void parserInterfaceToProxy() throws Exception { // then Assertions.assertNotNull(proxyInvocationHandler); } + + @Test + void shouldExcludePrivateMethodsFromProxy() throws Exception { Review Comment: The test name `shouldExcludePrivateMethodsFromProxy` doesn't fully capture what the test verifies. The test actually verifies that non-private methods (default and protected) ARE included while private methods are excluded. Consider a more descriptive name like `shouldIncludeNonPrivateMethodsAndExcludePrivateMethodsFromProxy` or `shouldProxyOnlyNonPrivateMethods` to better communicate the complete behavior being tested. ```suggestion void shouldProxyOnlyNonPrivateMethods() throws Exception { ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
