funky-eyes commented on PR #7924: URL: https://github.com/apache/incubator-seata/pull/7924#issuecomment-3734057213
> Thank you for the review @funky-eyes! > > You're right - looking at the Codecov report, the coverage didn't increase because the SeataProperties class methods (getters/setters) are simple property accessors that may already be covered by other integration tests. > > I can either: > > 1. **Close this PR** if the existing coverage is sufficient > 2. **Add more meaningful tests** for other uncovered classes in seata-spring-boot-starter module > > Please let me know which approach you prefer. I'm happy to contribute more comprehensive tests for classes that actually need coverage improvement. > > Looking at issue #6505, the goal is to reach 70% coverage for the module. Would you like me to identify specific classes that need test coverage and create a new PR targeting those? Thank you for your contribution. I agree with your suggestion — we should review the Codecov report to identify classes with insufficient unit-test coverage and add corresponding test cases for them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
