maple525866 commented on code in PR #7760: URL: https://github.com/apache/incubator-seata/pull/7760#discussion_r2679264027
########## json-common/src/main/java/org/apache/seata/common/json/JsonSerializerFactory.java: ########## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.seata.common.json; + +import org.apache.seata.common.loader.EnhancedServiceLoader; +import org.apache.seata.common.util.CollectionUtils; + +import java.util.Map; +import java.util.Optional; +import java.util.concurrent.ConcurrentHashMap; + +public class JsonSerializerFactory { + + private static final String DEFAULT_SERIALIZER = "jackson"; + + private static final Map<String, org.apache.seata.common.json.JsonSerializer> INSTANCES = new ConcurrentHashMap<>(); Review Comment: Remove "org.apache.seata.common.json." and replace it with "import". ########## json-common/src/main/java/org/apache/seata/common/json/JsonSerializerFactory.java: ########## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.seata.common.json; + +import org.apache.seata.common.loader.EnhancedServiceLoader; +import org.apache.seata.common.util.CollectionUtils; + +import java.util.Map; +import java.util.Optional; +import java.util.concurrent.ConcurrentHashMap; + +public class JsonSerializerFactory { + + private static final String DEFAULT_SERIALIZER = "jackson"; + + private static final Map<String, org.apache.seata.common.json.JsonSerializer> INSTANCES = new ConcurrentHashMap<>(); + + private JsonSerializerFactory() {} + + /** + * Get JsonSerializer instance by name. + * + * @param name the serializer name (e.g., "fastjson", "jackson", "gson") + * @return the JsonSerializer instance + */ + public static org.apache.seata.common.json.JsonSerializer getSerializer(String name) { + final String serializerName = Optional.ofNullable(name).orElse(DEFAULT_SERIALIZER); + return CollectionUtils.computeIfAbsent( Review Comment: ditto, and check other changed files for any other similar issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
