Sumit6307 opened a new pull request, #7981:
URL: https://github.com/apache/incubator-seata/pull/7981
Implemented the TODO item in DataSourceProxy.close() to ensure that
resources are properly unregistered from the
DefaultResourceManager
when the proxy is closed. This prevents potential resource leaks by
ensuring DefaultResourceManager.get().unregisterResource(this) is called.
Ⅱ. Does this pull request fix one issue?
Fixes missing resource cleanup in
DataSourceProxy
.
Ⅲ. Why don't you add test cases (unit test/integration test)?
I have updated the existing unit test
DataSourceProxyTest
. Specifically, I modified
testCloseRemovesResource
to verify that
unregisterResource
is called when the proxy is closed.
Ⅳ. Describe how to verify it
Run the unit tests for the datasource module: mvn -pl rm-datasource
-Dtest=DataSourceProxyTest test
Ⅴ. Special notes for reviews
This change simply addresses an existing TODO comment to ensure cleaner
resource lifecycle management.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
