Abhishekmishra2808 commented on issue #7854:
URL:
https://github.com/apache/incubator-seata/issues/7854#issuecomment-3823473165
@funky-eyes @l81893521
Hello! I would like to help with this issue. After reviewing the
requirements, here is my proposed plan to replace the P3C plugin and improve PR
style checks while ensuring JDK 21+ compatibility.
## Phase 1: Research & Tool Selection
- Evaluate modern, JDK-21-compatible alternatives:
- **Checkstyle** for rule enforcement (highly configurable and closely
aligned with Alibaba Java Coding Guidelines).
- **Spotless** for formatting and auto-apply support.
- Map existing P3C rules to an equivalent Checkstyle ruleset to avoid any
regression in code quality.
## Phase 2: Integration & Migration
- Introduce the selected tool(s) in the root `pom.xml`, ensuring full
compatibility with JDK 21+.
- If required, perform a one-time baseline formatting **in a dedicated PR**,
subject to maintainer approval.
- Provide simple local commands (e.g. `mvn spotless:apply`) so contributors
can fix style issues before pushing.
## Phase 3: CI & PR Feedback
- Integrate style checks into the existing GitHub Actions pipeline to
validate pull requests.
- Explore PR feedback tooling (e.g. ReviewDog or Spotless Action) to:
- Comment inline on specific style violations.
- Optionally auto-fix formatting issues, based on maintainer preference.
## Next Steps
- Start with a small proof of concept (PoC) using **Checkstyle + Spotless**
configured with Alibaba-style rules.
- Share findings and gather maintainer feedback before proceeding further.
Please let me know if there is a preferred direction or tooling choice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
