sunbufu commented on issue #2701: Log configuration from reg center into log files URL: https://github.com/apache/incubator-shardingsphere/pull/2701#issuecomment-511092713 > I don't think simply printing the logs in unit tests (without assertions) is a good practice. Your tests pass even when the printer prints wrong logs, which makes the tests useless. > > I'd suggest mocking the `log` in class `ConfigurationPrinter` and `verify` the `log.info` method with expected parameters You are right, and I will mock a `log` on `ConfigurationPrinterTest`.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
