terrymanu commented on a change in pull request #2949: 4.0.0-RC2 does not
support Oracle 12C connection configuration #2911
URL:
https://github.com/apache/incubator-shardingsphere/pull/2949#discussion_r324965404
##########
File path:
sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/datasource/DataSourceMetas.java
##########
@@ -33,21 +33,22 @@
* @author panjuan
*/
public final class DataSourceMetas {
-
+
private final Map<String, DataSourceMetaData> dataSourceMetaDataMap;
-
+ private final DatabaseType databaseTypeInfo;
Review comment:
May leave a blank line during 2 lines of variable declaration
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
