tristaZero commented on a change in pull request #3276: Add table owner for logic encrypt column URL: https://github.com/apache/incubator-shardingsphere/pull/3276#discussion_r335270389
########## File path: sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/sql/segment/dml/column/ColumnSegment.java ########## @@ -65,6 +65,15 @@ public ColumnSegment(final int startIndex, final int stopIndex, final String nam public final String getQualifiedName() { return null == owner ? name : owner.getTableName() + "." + name; } + + /** + * Get owner name. + * + * @return owner name + */ + public final String getOwnerName() { + return null == owner ? null : owner.getTableName(); Review comment: Thanks for your reply, there are tableName and alias in `TableSegment`, when getTableName(), it should not return alias actually. But you are right, getTableName() return alias in `EncryptSQLRewriteEngineParameterizedTest` , which is an another issue. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services