sandynz commented on code in PR #20316:
URL: https://github.com/apache/shardingsphere/pull/20316#discussion_r950947797
##########
shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/rdl/rule/RuleDefinitionBackendHandler.java:
##########
@@ -60,9 +51,6 @@
@Slf4j
public final class RuleDefinitionBackendHandler<T extends
RuleDefinitionStatement> extends DatabaseRequiredBackendHandler<T> {
- private static final Set<String> RULE_ALTERED_ACTIONS = new
HashSet<>(Arrays.asList(AlterShardingTableRuleStatement.class.getName(),
AlterShardingAlgorithmStatement.class.getName(),
- AlterDefaultShardingStrategyStatement.class.getName(),
AlterShardingBindingTableRulesStatement.class.getName(),
AlterShardingBroadcastTableRulesStatement.class.getName()));
Review Comment:
We could keep it, it'll be used later
##########
shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-core/src/main/java/org/apache/shardingsphere/data/pipeline/core/check/consistency/DataConsistencyChecker.java:
##########
@@ -77,8 +81,9 @@ public final class DataConsistencyChecker {
public DataConsistencyChecker(final MigrationJobConfiguration jobConfig,
final JobRateLimitAlgorithm readRateLimitAlgorithm) {
this.jobConfig = jobConfig;
- logicTableNames = jobConfig.splitLogicTableNames();
- tableNameSchemaNameMapping = new
TableNameSchemaNameMapping(TableNameSchemaNameMapping.convert(jobConfig.getSchemaTablesMap()));
+ logicTableNames =
Collections.singletonList(jobConfig.getTargetTableName());
+ Map<String, List<String>> schemaTablesMap =
SchemaTableUtil.getSchemaTablesMap(jobConfig.getTargetDatabaseName(),
Collections.singleton(jobConfig.getTargetTableName()));
+ tableNameSchemaNameMapping = new
TableNameSchemaNameMapping(TableNameSchemaNameMapping.convert(schemaTablesMap));
Review Comment:
We could still use `jobConfig.getSchemaTablesMap()` to translate table name
and schema name, and use
`SchemaTableUtil.getSchemaTablesMap(jobConfig.getTargetDatabaseName(),
Collections.singleton(jobConfig.getTargetTableName()))` to get database
metadata.
Since database metadata schema will use logical database name as schema name
in MySQL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
