[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #21037: Refactor view metadata load and persist logic

[GitBox]

strongduanmu commented on code in PR #21037:
URL: https://github.com/apache/shardingsphere/pull/21037#discussion_r973635048


##########
shardingsphere-mode/shardingsphere-mode-core/src/main/java/org/apache/shardingsphere/mode/metadata/persist/service/schema/ViewMetaDataPersistService.java:
##########
@@ -42,9 +41,7 @@ public final class ViewMetaDataPersistService implements 
SchemaMetaDataPersistSe
     
     @Override
     public void compareAndPersist(final String databaseName, final String 
schemaName, final Map<String, ShardingSphereView> loadedViews) {
-        Map<String, ShardingSphereView> currentViews = load(databaseName, 
schemaName);
-        persist(databaseName, schemaName, 
SchemaManager.getToBeAddedViews(loadedViews, currentViews));
-        SchemaManager.getToBeDeletedViews(loadedViews, 
currentViews).forEach((key, value) -> delete(databaseName, schemaName, key));
+        

Review Comment:
   Please remove useless blank line.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org