This is an automated email from the ASF dual-hosted git repository.

duanzhengqiang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/shardingsphere-on-cloud.git


The following commit(s) were added to refs/heads/main by this push:
     new 2dcb5d8  fix(test): fix unit test for shardingsphere-operator,remove 
webhook and controller unit test
     new 61277a2  Merge pull request #84 from windghoul/test
2dcb5d8 is described below

commit 2dcb5d8f1ce614dd90c936703d3e491cba338108
Author: windghoul <[email protected]>
AuthorDate: Sat Oct 8 16:25:06 2022 +0800

    fix(test): fix unit test for shardingsphere-operator,remove webhook and 
controller unit test
    
    Signed-off-by: windghoul <[email protected]>
---
 .../api/v1alpha1/webhook_suite_test.go             | 131 ---------------------
 .../pkg/controllers/suite_test.go                  |  78 ------------
 2 files changed, 209 deletions(-)

diff --git a/shardingsphere-operator/api/v1alpha1/webhook_suite_test.go 
b/shardingsphere-operator/api/v1alpha1/webhook_suite_test.go
deleted file mode 100644
index a76343d..0000000
--- a/shardingsphere-operator/api/v1alpha1/webhook_suite_test.go
+++ /dev/null
@@ -1,131 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements.  See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License.  You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package v1alpha1
-
-import (
-       "context"
-       "crypto/tls"
-       "fmt"
-       "net"
-       "path/filepath"
-       "testing"
-       "time"
-
-       admissionv1beta1 "k8s.io/api/admission/v1beta1"
-       //+kubebuilder:scaffold:imports
-       "k8s.io/apimachinery/pkg/runtime"
-       "k8s.io/client-go/rest"
-       ctrl "sigs.k8s.io/controller-runtime"
-       "sigs.k8s.io/controller-runtime/pkg/client"
-       "sigs.k8s.io/controller-runtime/pkg/envtest"
-       "sigs.k8s.io/controller-runtime/pkg/envtest/printer"
-       logf "sigs.k8s.io/controller-runtime/pkg/log"
-       "sigs.k8s.io/controller-runtime/pkg/log/zap"
-)
-
-// These tests use Ginkgo (BDD-style Go testing framework). Refer to
-// http://onsi.github.io/ginkgo/ to learn more about Ginkgo.
-
-var cfg *rest.Config
-var k8sClient client.Client
-var testEnv *envtest.Environment
-var ctx context.Context
-var cancel context.CancelFunc
-
-func TestAPIs(t *testing.T) {
-       RegisterFailHandler(Fail)
-
-       RunSpecsWithDefaultAndCustomReporters(t,
-               "Webhook Suite",
-               []Reporter{printer.NewlineReporter{}})
-}
-
-var _ = BeforeSuite(func() {
-       logf.SetLogger(zap.New(zap.WriteTo(GinkgoWriter), zap.UseDevMode(true)))
-
-       ctx, cancel = context.WithCancel(context.TODO())
-
-       By("bootstrapping test environment")
-       testEnv = &envtest.Environment{
-               CRDDirectoryPaths:     []string{filepath.Join("..", "..", 
"config", "crd", "bases")},
-               ErrorIfCRDPathMissing: false,
-               WebhookInstallOptions: envtest.WebhookInstallOptions{
-                       Paths: []string{filepath.Join("..", "..", "config", 
"webhook")},
-               },
-       }
-
-       cfg, err := testEnv.Start()
-       Expect(err).NotTo(HaveOccurred())
-       Expect(cfg).NotTo(BeNil())
-
-       scheme := runtime.NewScheme()
-       err = AddToScheme(scheme)
-       Expect(err).NotTo(HaveOccurred())
-
-       err = admissionv1beta1.AddToScheme(scheme)
-       Expect(err).NotTo(HaveOccurred())
-
-       //+kubebuilder:scaffold:scheme
-
-       k8sClient, err = client.New(cfg, client.Options{Scheme: scheme})
-       Expect(err).NotTo(HaveOccurred())
-       Expect(k8sClient).NotTo(BeNil())
-
-       // start webhook server using Manager
-       webhookInstallOptions := &testEnv.WebhookInstallOptions
-       mgr, err := ctrl.NewManager(cfg, ctrl.Options{
-               Scheme:             scheme,
-               Host:               webhookInstallOptions.LocalServingHost,
-               Port:               webhookInstallOptions.LocalServingPort,
-               CertDir:            webhookInstallOptions.LocalServingCertDir,
-               LeaderElection:     false,
-               MetricsBindAddress: "0",
-       })
-       Expect(err).NotTo(HaveOccurred())
-
-       err = (&ShardingSphereProxy{}).SetupWebhookWithManager(mgr)
-       Expect(err).NotTo(HaveOccurred())
-
-       //+kubebuilder:scaffold:webhook
-
-       go func() {
-               defer GinkgoRecover()
-               err = mgr.Start(ctx)
-               Expect(err).NotTo(HaveOccurred())
-       }()
-
-       // wait for the webhook server to get ready
-       dialer := &net.Dialer{Timeout: time.Second}
-       addrPort := fmt.Sprintf("%s:%d", 
webhookInstallOptions.LocalServingHost, webhookInstallOptions.LocalServingPort)
-       Eventually(func() error {
-               conn, err := tls.DialWithDialer(dialer, "tcp", addrPort, 
&tls.Config{InsecureSkipVerify: true})
-               if err != nil {
-                       return err
-               }
-               conn.Close()
-               return nil
-       }).Should(Succeed())
-
-}, 60)
-
-var _ = AfterSuite(func() {
-       cancel()
-       By("tearing down the test environment")
-       err := testEnv.Stop()
-       Expect(err).NotTo(HaveOccurred())
-})
diff --git a/shardingsphere-operator/pkg/controllers/suite_test.go 
b/shardingsphere-operator/pkg/controllers/suite_test.go
deleted file mode 100644
index 4b52c9d..0000000
--- a/shardingsphere-operator/pkg/controllers/suite_test.go
+++ /dev/null
@@ -1,78 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements.  See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License.  You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package controllers
-
-import (
-       shardingspherev1alpha1 
"github.com/apache/shardingsphere-on-cloud/shardingsphere-operator/api/v1alpha1"
-       "path/filepath"
-       "testing"
-
-       "k8s.io/client-go/kubernetes/scheme"
-       "k8s.io/client-go/rest"
-       "sigs.k8s.io/controller-runtime/pkg/client"
-       "sigs.k8s.io/controller-runtime/pkg/envtest"
-       "sigs.k8s.io/controller-runtime/pkg/envtest/printer"
-       logf "sigs.k8s.io/controller-runtime/pkg/log"
-       "sigs.k8s.io/controller-runtime/pkg/log/zap"
-       //+kubebuilder:scaffold:imports
-)
-
-// These tests use Ginkgo (BDD-style Go testing framework). Refer to
-// http://onsi.github.io/ginkgo/ to learn more about Ginkgo.
-
-var cfg *rest.Config
-var k8sClient client.Client
-var testEnv *envtest.Environment
-
-func TestAPIs(t *testing.T) {
-       RegisterFailHandler(Fail)
-
-       RunSpecsWithDefaultAndCustomReporters(t,
-               "Controller Suite",
-               []Reporter{printer.NewlineReporter{}})
-}
-
-var _ = BeforeSuite(func() {
-       logf.SetLogger(zap.New(zap.WriteTo(GinkgoWriter), zap.UseDevMode(true)))
-
-       By("bootstrapping test environment")
-       testEnv = &envtest.Environment{
-               CRDDirectoryPaths:     []string{filepath.Join("..", "config", 
"crd", "bases")},
-               ErrorIfCRDPathMissing: true,
-       }
-
-       cfg, err := testEnv.Start()
-       Expect(err).NotTo(HaveOccurred())
-       Expect(cfg).NotTo(BeNil())
-
-       err = shardingspherev1alpha1.AddToScheme(scheme.Scheme)
-       Expect(err).NotTo(HaveOccurred())
-
-       //+kubebuilder:scaffold:scheme
-
-       k8sClient, err = client.New(cfg, client.Options{Scheme: scheme.Scheme})
-       Expect(err).NotTo(HaveOccurred())
-       Expect(k8sClient).NotTo(BeNil())
-
-}, 60)
-
-var _ = AfterSuite(func() {
-       By("tearing down the test environment")
-       err := testEnv.Stop()
-       Expect(err).NotTo(HaveOccurred())
-})

Reply via email to