linghengqian commented on code in PR #21657:
URL: https://github.com/apache/shardingsphere/pull/21657#discussion_r1001385993
##########
distribution/proxy-native/pom.xml:
##########
@@ -67,6 +67,35 @@
</dependencies>
<profiles>
+ <profile>
+ <id>release</id>
Review Comment:
- I looked at the `Dockerfile` and release process of `distribution/proxy`
and found that all the raw materials used to build the Docker Image are
extracted from the `.tar.gz` file generated by the release profile.
- Is this an unwritten rule, or is it possible to make a Docker Image
without making an intermediate `.tar.gz`? I'm not quite sure if `.tar.gz` is
only needed for distributing binaries.
- If this provision exists, I will fix the `Dockerfile` of
`distribution/proxy-native` when opening a new PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
