RaigorJiang commented on code in PR #23125:
URL: https://github.com/apache/shardingsphere/pull/23125#discussion_r1058073851
##########
features/db-discovery/distsql/handler/src/main/java/org/apache/shardingsphere/dbdiscovery/distsql/handler/update/AlterDatabaseDiscoveryRuleStatementUpdater.java:
##########
@@ -75,7 +75,7 @@ private Collection<String> getToBeAlteredRuleNames(final
AlterDatabaseDiscoveryR
private void checkToBeAlteredResources(final String databaseName, final
AlterDatabaseDiscoveryRuleStatement sqlStatement, final
ShardingSphereResourceMetaData resourceMetaData) {
Collection<String> notExistedResources =
resourceMetaData.getNotExistedResources(getToBeAlteredResourceNames(sqlStatement));
Review Comment:
Should rename `notExistedResources` to `notExistedStorageUnits`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
