This is an automated email from the ASF dual-hosted git repository.

tuichenchuxin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 0e8c0a61b08 Remove duplicate newShardingSphereSchema method (#23448)
0e8c0a61b08 is described below

commit 0e8c0a61b0818bdf0dff1be589cc1b34d6a756e4
Author: zhaojinchao <[email protected]>
AuthorDate: Tue Jan 10 09:32:32 2023 +0800

    Remove duplicate newShardingSphereSchema method (#23448)
---
 .../shardingsphere/mode/manager/ContextManager.java   | 19 +------------------
 1 file changed, 1 insertion(+), 18 deletions(-)

diff --git 
a/mode/core/src/main/java/org/apache/shardingsphere/mode/manager/ContextManager.java
 
b/mode/core/src/main/java/org/apache/shardingsphere/mode/manager/ContextManager.java
index eb5fb4835bf..3f86853ab5e 100644
--- 
a/mode/core/src/main/java/org/apache/shardingsphere/mode/manager/ContextManager.java
+++ 
b/mode/core/src/main/java/org/apache/shardingsphere/mode/manager/ContextManager.java
@@ -236,8 +236,7 @@ public final class ContextManager implements AutoCloseable {
             MetaDataContexts reloadMetaDataContexts = 
createMetaDataContexts(databaseName, null, ruleConfigs);
             alterSchemaMetaData(databaseName, 
reloadMetaDataContexts.getMetaData().getDatabase(databaseName), 
metaDataContexts.getMetaData().getDatabase(databaseName));
             metaDataContexts = reloadMetaDataContexts;
-            
metaDataContexts.getMetaData().getDatabase(databaseName).getSchemas().putAll(newShardingSphereSchema(databaseName,
-                    
metaDataContexts.getMetaData().getDatabase(databaseName).getSchemas()));
+            
metaDataContexts.getMetaData().getDatabase(databaseName).getSchemas().putAll(newShardingSphereSchemas(metaDataContexts.getMetaData().getDatabase(databaseName)));
         } catch (final SQLException ex) {
             log.error("Alter database: {} rule configurations failed", 
databaseName, ex);
         }
@@ -397,22 +396,6 @@ public final class ContextManager implements AutoCloseable 
{
         return result;
     }
     
-    /**
-     * Create new ShardingSphere database.
-     *
-     * @param databasesName database name
-     * @param schemas schemas
-     * @return ShardingSphere schemas
-     */
-    public synchronized Map<String, ShardingSphereSchema> 
newShardingSphereSchema(final String databasesName, final Map<String, 
ShardingSphereSchema> schemas) {
-        Map<String, ShardingSphereSchema> result = new 
LinkedHashMap<>(schemas.size(), 1);
-        for (Entry<String, ShardingSphereSchema> entry : schemas.entrySet()) {
-            result.put(entry.getKey(), new 
ShardingSphereSchema(entry.getValue().getTables(),
-                    
metaDataContexts.getPersistService().getDatabaseMetaDataService().getViewMetaDataPersistService().load(databasesName,
 entry.getKey())));
-        }
-        return result;
-    }
-    
     /**
      * Create new ShardingSphere database.
      *

Reply via email to