sandynz opened a new pull request, #24285:
URL: https://github.com/apache/shardingsphere/pull/24285
Fixes #24210.
Changes proposed in this pull request:
- Add unit test: insert data into varbinary column table
- Update IndexesMigrationE2EIT to test varbinary sharding column
- Support inserting data into varbinary sharding column table. Remove or
replace related `Comparable<?>` for sharding algorithm `hash_mod`
sharding algorithm `mod` is not supported for varbinary, since
`ModShardingAlgorithm.cutShardingValue`:
```
private BigInteger cutShardingValue(final Comparable<?> shardingValue) {
ShardingSpherePreconditions.checkState(shardingValue.toString().length() -
stopOffset > startOffset, () -> new ShardingValueOffsetException(shardingValue,
startOffset, stopOffset));
return 0 == startOffset && 0 == stopOffset ?
getBigInteger(shardingValue) : new
BigInteger(shardingValue.toString().substring(startOffset,
shardingValue.toString().length() - stopOffset));
}
```
byte[].toString() is not suitable for `cutShardingValue`.
And also other sharding algorithms are not supported for varbinary.
---
Before committing this PR, I'm sure that I have checked the following
options:
- [ ] My code follows the [code of
conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/)
of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the
pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C
-Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
