strongduanmu commented on code in PR #24888:
URL: https://github.com/apache/shardingsphere/pull/24888#discussion_r1156924684
##########
sql-parser/dialect/mysql/src/main/java/org/apache/shardingsphere/sql/parser/mysql/visitor/statement/impl/MySQLStatementSQLVisitor.java:
##########
@@ -954,7 +954,12 @@ public final ASTNode visitExtractFunction(final
ExtractFunctionContext ctx) {
@Override
public final ASTNode visitCharFunction(final CharFunctionContext ctx) {
calculateParameterCount(ctx.expr());
- return new FunctionSegment(ctx.getStart().getStartIndex(),
ctx.getStop().getStopIndex(), ctx.CHAR().getText(), getOriginalText(ctx));
+ FunctionSegment result = new
FunctionSegment(ctx.getStart().getStartIndex(), ctx.getStop().getStopIndex(),
ctx.CHAR().getText(), getOriginalText(ctx));
+ for (ExprContext each : ctx.expr()) {
+ ASTNode expr = visit(each);
+ result.getParameters().add((LiteralExpressionSegment) expr);
Review Comment:
Do you think use `(ExpressionSegment) visit(ctx.expr())` is better?
`(LiteralExpressionSegment) visit(ctx.expr())` will cause class cast exception.
##########
sql-parser/dialect/mysql/src/main/java/org/apache/shardingsphere/sql/parser/mysql/visitor/statement/impl/MySQLStatementSQLVisitor.java:
##########
@@ -966,7 +971,9 @@ public final ASTNode visitTrimFunction(final
TrimFunctionContext ctx) {
@Override
public final ASTNode visitWeightStringFunction(final
WeightStringFunctionContext ctx) {
calculateParameterCount(Collections.singleton(ctx.expr()));
- return new FunctionSegment(ctx.getStart().getStartIndex(),
ctx.getStop().getStopIndex(), ctx.WEIGHT_STRING().getText(),
getOriginalText(ctx));
+ FunctionSegment result = new
FunctionSegment(ctx.getStart().getStartIndex(), ctx.getStop().getStopIndex(),
ctx.WEIGHT_STRING().getText(), getOriginalText(ctx));
+ result.getParameters().add((LiteralExpressionSegment)
visit(ctx.expr()));
Review Comment:
Do you think use `(ExpressionSegment) visit(ctx.expr())` is better?
`(LiteralExpressionSegment) visit(ctx.expr())` will cause class cast exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
