Pace2Car commented on issue #24752: URL: https://github.com/apache/shardingsphere/issues/24752#issuecomment-1498426932
> Hi, does my pull request satisfy the demand? hopes have some suggestions. Hi @QiangYuan0828, Thanks for your PR, but it seems that these checks are unnecessary in your PR, The target described in the main issue(#24746) is to improve the properties verification in the `init` method. For example, in `WeightReadQueryLoadBalanceAlgorithm.init()`, the data sources must not be empty, and the weight of data source must be configured BTW: use `ShardingSpherePreconditions.checkState` like other checks do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
