strongduanmu commented on code in PR #27228:
URL: https://github.com/apache/shardingsphere/pull/27228#discussion_r1266099880


##########
parser/sql/dialect/oracle/src/main/java/org/apache/shardingsphere/sql/parser/oracle/visitor/statement/OracleStatementVisitor.java:
##########
@@ -850,4 +943,775 @@ public final ASTNode visitDataTypeLength(final 
DataTypeLengthContext ctx) {
     protected String getOriginalText(final ParserRuleContext ctx) {
         return ctx.start.getInputStream().getText(new 
Interval(ctx.start.getStartIndex(), ctx.stop.getStopIndex()));
     }
+    
+    @Override
+    public ASTNode visitSelect(final SelectContext ctx) {

Review Comment:
   Besides, we should merge `private final Collection<ParameterMarkerSegment> 
parameterMarkerSegments = new LinkedList<>();` if we use `new 
OracleDMLStatementVisitor().visit()`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to