strongduanmu commented on code in PR #28028:
URL: https://github.com/apache/shardingsphere/pull/28028#discussion_r1292118925
##########
parser/sql/dialect/oracle/src/main/antlr4/imports/oracle/DDLStatement.g4:
##########
@@ -220,7 +220,21 @@ oidIndexClause
;
createRelationalTableClause
- : (LP_ relationalProperties RP_) collationClause? commitClause?
physicalProperties? tableProperties?
+ : (LP_ relationalProperties RP_)
Review Comment:
Can you test with JMH? The new way of writing looks more complicated, we
need to know how much performance can be improved by this way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
