134130 commented on code in PR #25074:
URL: https://github.com/apache/shardingsphere/pull/25074#discussion_r1327933490
##########
kernel/sql-federation/executor/core/src/main/java/org/apache/shardingsphere/sqlfederation/executor/FilterableTableScanExecutor.java:
##########
@@ -252,28 +252,16 @@ private Collection<RexNode> createProjections(final int[]
projects, final RelBui
private AbstractEnumerable<Object[]> createEnumerable(final MergedResult
mergedResult, final QueryResultMetaData metaData, final Collection<Statement>
statements) throws SQLException {
// TODO remove getRows when mergedResult support JDBC first method
Review Comment:
Do this TODO comment is valid after this refactor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
