linghengqian commented on code in PR #28326:
URL: https://github.com/apache/shardingsphere/pull/28326#discussion_r1334999295


##########
pom.xml:
##########
@@ -1235,7 +1256,6 @@
                             <excludes>
                                 
<exclude>org.apache.shardingsphere.agent.core.**</exclude>
                             </excludes>
-                            <argLine>--add-opens 
java.base/java.lang=ALL-UNNAMED --add-opens 
java.base/java.lang.reflect=ALL-UNNAMED</argLine>

Review Comment:
   - It is impossible for the Maven Profile of `generateStandardMetadata` to 
run on JDK8.  This Maven Profile is restricted to run on JDK17-JDK21 through 
`maven-compiler-plugin`.  
   
   - In addition, the Maven Profile of `jdk11+` also defines the same.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to