strongduanmu commented on code in PR #28724:
URL: https://github.com/apache/shardingsphere/pull/28724#discussion_r1357853180
##########
infra/common/src/test/java/org/apache/shardingsphere/infra/metadata/database/rule/RuleMetaDataTest.java:
##########
@@ -42,6 +55,102 @@ void assertFindSingleRule() {
@Test
void assertGetSingleRule() {
-
assertThat(ruleMetaData.getSingleRule(ShardingSphereRuleFixture.class),
instanceOf(ShardingSphereRuleFixture.class));
+ assertThat(ruleMetaData.getSingleRule(ShardingSphereRuleFixture.class),
+ instanceOf(ShardingSphereRuleFixture.class));
+ }
+
+ @Test
+ void assertGetInUsedStorageUnitNameAndRulesMapWhenRulesAreEmpty() {
+ Collection<ShardingSphereRule> rules = new ArrayList<>();
+ RuleMetaData r = new RuleMetaData(rules);
Review Comment:
Do you think ruleMetaData is better?
##########
infra/common/src/test/java/org/apache/shardingsphere/infra/metadata/database/rule/RuleMetaDataTest.java:
##########
@@ -42,6 +55,102 @@ void assertFindSingleRule() {
@Test
void assertGetSingleRule() {
-
assertThat(ruleMetaData.getSingleRule(ShardingSphereRuleFixture.class),
instanceOf(ShardingSphereRuleFixture.class));
+ assertThat(ruleMetaData.getSingleRule(ShardingSphereRuleFixture.class),
+ instanceOf(ShardingSphereRuleFixture.class));
+ }
+
+ @Test
+ void assertGetInUsedStorageUnitNameAndRulesMapWhenRulesAreEmpty() {
+ Collection<ShardingSphereRule> rules = new ArrayList<>();
+ RuleMetaData r = new RuleMetaData(rules);
+ Map<String, Collection<Class<? extends ShardingSphereRule>>> actual =
r.getInUsedStorageUnitNameAndRulesMap();
+
Review Comment:
Please remove this useless blank line.
##########
infra/common/src/test/java/org/apache/shardingsphere/infra/metadata/database/rule/RuleMetaDataTest.java:
##########
@@ -42,6 +55,102 @@ void assertFindSingleRule() {
@Test
void assertGetSingleRule() {
-
assertThat(ruleMetaData.getSingleRule(ShardingSphereRuleFixture.class),
instanceOf(ShardingSphereRuleFixture.class));
+ assertThat(ruleMetaData.getSingleRule(ShardingSphereRuleFixture.class),
+ instanceOf(ShardingSphereRuleFixture.class));
+ }
+
+ @Test
+ void assertGetInUsedStorageUnitNameAndRulesMapWhenRulesAreEmpty() {
+ Collection<ShardingSphereRule> rules = new ArrayList<>();
+ RuleMetaData r = new RuleMetaData(rules);
+ Map<String, Collection<Class<? extends ShardingSphereRule>>> actual =
r.getInUsedStorageUnitNameAndRulesMap();
+
+ assertEquals(0, actual.size());
Review Comment:
Please use assertThat instead of assertEquals.
##########
infra/common/src/test/java/org/apache/shardingsphere/infra/metadata/database/rule/RuleMetaDataTest.java:
##########
@@ -42,6 +55,102 @@ void assertFindSingleRule() {
@Test
void assertGetSingleRule() {
-
assertThat(ruleMetaData.getSingleRule(ShardingSphereRuleFixture.class),
instanceOf(ShardingSphereRuleFixture.class));
+ assertThat(ruleMetaData.getSingleRule(ShardingSphereRuleFixture.class),
+ instanceOf(ShardingSphereRuleFixture.class));
+ }
+
+ @Test
+ void assertGetInUsedStorageUnitNameAndRulesMapWhenRulesAreEmpty() {
+ Collection<ShardingSphereRule> rules = new ArrayList<>();
+ RuleMetaData r = new RuleMetaData(rules);
+ Map<String, Collection<Class<? extends ShardingSphereRule>>> actual =
r.getInUsedStorageUnitNameAndRulesMap();
+
+ assertEquals(0, actual.size());
+ }
+
+ @Test
+ void
assertGetInUsedStorageUnitNameAndRulesMapWhenRulesContainDataNodeContainedRule()
{
+ Collection<ShardingSphereRule> rules = new ArrayList<>();
+ DataNodeContainedRule rule = new MockDataNodeContainedRule();
+ rules.add(rule);
+ RuleMetaData r = new RuleMetaData(rules);
+ Map<String, Collection<Class<? extends ShardingSphereRule>>> actual =
r.getInUsedStorageUnitNameAndRulesMap();
+
Review Comment:
Please remove this useless blank line.
##########
infra/common/src/test/java/org/apache/shardingsphere/infra/metadata/database/rule/RuleMetaDataTest.java:
##########
@@ -42,6 +55,102 @@ void assertFindSingleRule() {
@Test
void assertGetSingleRule() {
-
assertThat(ruleMetaData.getSingleRule(ShardingSphereRuleFixture.class),
instanceOf(ShardingSphereRuleFixture.class));
+ assertThat(ruleMetaData.getSingleRule(ShardingSphereRuleFixture.class),
+ instanceOf(ShardingSphereRuleFixture.class));
+ }
+
+ @Test
+ void assertGetInUsedStorageUnitNameAndRulesMapWhenRulesAreEmpty() {
+ Collection<ShardingSphereRule> rules = new ArrayList<>();
+ RuleMetaData r = new RuleMetaData(rules);
+ Map<String, Collection<Class<? extends ShardingSphereRule>>> actual =
r.getInUsedStorageUnitNameAndRulesMap();
+
+ assertEquals(0, actual.size());
+ }
+
+ @Test
+ void
assertGetInUsedStorageUnitNameAndRulesMapWhenRulesContainDataNodeContainedRule()
{
+ Collection<ShardingSphereRule> rules = new ArrayList<>();
+ DataNodeContainedRule rule = new MockDataNodeContainedRule();
+ rules.add(rule);
+ RuleMetaData r = new RuleMetaData(rules);
+ Map<String, Collection<Class<? extends ShardingSphereRule>>> actual =
r.getInUsedStorageUnitNameAndRulesMap();
+
+ assertEquals(1, actual.size());
+ assertTrue(actual.containsKey("testDataNodeSourceName"));
+ assertEquals(1, actual.get("testDataNodeSourceName").size());
Review Comment:
Please use assertThat instead of assertEquals.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
