zihaoAK47 commented on code in PR #28762:
URL: https://github.com/apache/shardingsphere/pull/28762#discussion_r1361416759
##########
kernel/sql-federation/core/src/main/java/org/apache/shardingsphere/sqlfederation/compiler/metadata/schema/SQLFederationTable.java:
##########
@@ -124,4 +133,16 @@ public String toString() {
public Statistic getStatistic() {
return statistic;
}
+
+ @Override
+ public Collection<Object[]> getModifiableCollection() {
+ return new LinkedList<>();
Review Comment:
If the implementation of the getModifiableCollection method returns null, it
will trigger a NullPointerException for the EnumerableTableModify class.
However, for our implemented class EnumerableModify, it is allowed to return
null and it should not call the getModifiableCollection method in its future
implementations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
