sandynz commented on PR #28879:
URL: https://github.com/apache/shardingsphere/pull/28879#issuecomment-1784359340
Hi @HarshSawarkar , about newline related errors, you could ignore it for
now, we'll try to fix it. Thanks for your feedback.
About GitHub CI errors:
> CI / CI - Compile by JDK 11 and Run on JDK 8 (pull_request)
There's an error of `PipelineJobCenterTest`, you could run on local machine
to test and fix it:
```
Error:
org.apache.shardingsphere.data.pipeline.core.job.PipelineJobCenterTest.getJobItemContext
-- Time elapsed: 0.157 s <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <Mock for
PipelineJobItemContext, hashCode: 1250956357> but was: <Optional[Mock for
PipelineJobItemContext, hashCode: 1250956357]>
at
org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
at
org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
at
org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
at
org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
at
org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1141)
at
org.apache.shardingsphere.data.pipeline.core.job.PipelineJobCenterTest.getJobItemContext(PipelineJobCenterTest.java:57)
```
> Required - Check / Check - CheckStyle (pull_request)
These ones is caused by checkstyle, you could follow Code of Conduct:
```
If using IDEA, you can import the recommended
src/resources/code-style-idea.xml
```
And then format your code.
> Required - Check / Check - Spotless (pull_request)
You could follow Code of Conduct:
```
Through the uniform code style of spotless, execute the ./mvnw
spotless:apply -Pcheck formatted code.
```
> Required - Check / Check - License (pull_request)
You could copy a license header from another java file and add it into
`PipelineJobCenterTest.java`.
Other suggestions will be commented on PR review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
