(shardingsphere) branch master updated: Fix sonar issues on SingleMetaDataReviseEntryTest (#28891)

[sunnianjun]

This is an automated email from the ASF dual-hosted git repository.

sunnianjun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 7fa317fb87c Fix sonar issues on SingleMetaDataReviseEntryTest (#28891)
7fa317fb87c is described below

commit 7fa317fb87c087ba61ab95d0a00033d5c7839c97
Author: Liang Zhang <zhangli...@apache.org>
AuthorDate: Mon Oct 30 11:48:37 2023 +0800

    Fix sonar issues on SingleMetaDataReviseEntryTest (#28891)
    
    * Remove useless <groupId>org.apache.maven.plugins</groupId> declaration
    
    * Fix sonar issues on SingleMetaDataReviseEntryTest
---
 .../reviser/SingleMetaDataReviseEntryTest.java     | 48 +++++++---------------
 1 file changed, 15 insertions(+), 33 deletions(-)

diff --git 
a/kernel/single/core/src/test/java/org/apache/shardingsphere/single/metadata/reviser/SingleMetaDataReviseEntryTest.java
 
b/kernel/single/core/src/test/java/org/apache/shardingsphere/single/metadata/reviser/SingleMetaDataReviseEntryTest.java
index a9a251bd684..a197a724546 100644
--- 
a/kernel/single/core/src/test/java/org/apache/shardingsphere/single/metadata/reviser/SingleMetaDataReviseEntryTest.java
+++ 
b/kernel/single/core/src/test/java/org/apache/shardingsphere/single/metadata/reviser/SingleMetaDataReviseEntryTest.java
@@ -17,59 +17,41 @@
 
 package org.apache.shardingsphere.single.metadata.reviser;
 
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertTrue;
-
-import java.util.Collections;
-import java.util.HashMap;
-import java.util.Optional;
-
-import javax.sql.DataSource;
-
 import org.apache.shardingsphere.single.api.config.SingleRuleConfiguration;
-import org.apache.shardingsphere.single.constant.SingleOrder;
 import 
org.apache.shardingsphere.single.metadata.reviser.constraint.SingleConstraintReviser;
 import 
org.apache.shardingsphere.single.metadata.reviser.index.SingleIndexReviser;
 import org.apache.shardingsphere.single.rule.SingleRule;
-import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.Optional;
+
+import static org.hamcrest.CoreMatchers.is;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
 class SingleMetaDataReviseEntryTest {
     
-    private SingleMetaDataReviseEntry reviseEntry;
-    
-    @BeforeEach
-    public void setUp() {
-        reviseEntry = new SingleMetaDataReviseEntry();
-    }
+    private final SingleMetaDataReviseEntry reviseEntry = new 
SingleMetaDataReviseEntry();
     
     @Test
-    public void testGetIndexReviser() {
+    void assertGetIndexReviser() {
         SingleRuleConfiguration ruleConfig = new SingleRuleConfiguration();
-        SingleRule rule = new SingleRule(ruleConfig, "test_database", null, 
new HashMap<String, DataSource>(), Collections.emptyList());
+        SingleRule rule = new SingleRule(ruleConfig, "test_database", null, 
new HashMap<>(), Collections.emptyList());
         String tableName = "test_table";
         Optional<SingleIndexReviser> indexReviser = 
reviseEntry.getIndexReviser(rule, tableName);
         assertTrue(indexReviser.isPresent());
-        assertEquals(SingleIndexReviser.class, indexReviser.get().getClass());
+        assertThat(indexReviser.get().getClass(), 
is(SingleIndexReviser.class));
     }
     
     @Test
-    public void testGetConstraintReviser() {
+    void assertGetConstraintReviser() {
         SingleRuleConfiguration ruleConfig = new SingleRuleConfiguration();
-        SingleRule rule = new SingleRule(ruleConfig, "test_database", null, 
new HashMap<String, DataSource>(), Collections.emptyList());
+        SingleRule rule = new SingleRule(ruleConfig, "test_database", null, 
new HashMap<>(), Collections.emptyList());
         String tableName = "test_table";
         Optional<SingleConstraintReviser> constraintReviser = 
reviseEntry.getConstraintReviser(rule, tableName);
         assertTrue(constraintReviser.isPresent());
-        assertEquals(SingleConstraintReviser.class, 
constraintReviser.get().getClass());
-    }
-    
-    @Test
-    public void testGetOrder() {
-        assertEquals(SingleOrder.ORDER, reviseEntry.getOrder());
-    }
-    
-    @Test
-    public void testGetTypeClass() {
-        assertEquals(SingleRule.class, reviseEntry.getTypeClass());
+        assertThat(constraintReviser.get().getClass(), 
is(SingleConstraintReviser.class));
     }
 }