linghengqian opened a new pull request, #29008:
URL: https://github.com/apache/shardingsphere/pull/29008
For #28826.
Changes proposed in this pull request:
- Restore the slf4j version from 2.0.9 to 1.7.36 before Spring Boot 2 ends
the OSS life cycle.
- #28826 Increasing the slf4j version to 2.0.9 caused all downstreams
running ShardingSphere JDBC on Spring Boot 2.x to receive an Error.
- The Spring Boot side is restricted by the underlying design. The 2.x
branch of Spring Boot will use slf4j 1.x until the end of the OSS life cycle.
Due to changes in the API of the corresponding logback implementation, it is
impossible to use logback 1.3.x on Spring Boot 2.x. Reference
https://github.com/spring-projects/spring-boot/issues/34708.
- I believe the current PR will not affect Spring Boot 3 downstream,
because slf4j 2.0 is designed to be compatible with slf4j 1.x. The real issue
involved here is binary incompatibility between logback 1.2 and 1.3. I believe
we have to wait for Spring Boot 2 to end its OSS life cycle before we start
talking about slf4j 2.0.
- This PR also touches on the problem of bom not existing in slf4j 1.x.
---
Before committing this PR, I'm sure that I have checked the following
options:
- [x] My code follows the [code of
conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/)
of this project.
- [x] I have self-reviewed the commit code.
- [x] I have (or in comment I request) added corresponding labels for the
pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C
-Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
