linghengqian opened a new pull request, #29019:
URL: https://github.com/apache/shardingsphere/pull/29019
For #21347.
Changes proposed in this pull request:
- Prevent ReadwriteSplitting rule class from parsing Groovy syntax under
GraalVM Native Image. According to #21347, we need to block calls to
GroovyShell related classes under GraalVM Native Image.
- This PR brings out a magical hidden feature. In ReadwriteSplitting,
`<data_source_name>`, `<data_source_name>.write_data_source_name` and
`<data_source_name>.read_data_source_names` are allowed to be configured
through Groovy Expressions. No matter in the Example module, the unit tests do
not reflect this, and the documentation does not mention it. It looks like the
relevant unit test was removed in a past commit.
- Also for #29000 .
---
Before committing this PR, I'm sure that I have checked the following
options:
- [x] My code follows the [code of
conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/)
of this project.
- [x] I have self-reviewed the commit code.
- [x] I have (or in comment I request) added corresponding labels for the
pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C
-Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
