strongduanmu commented on code in PR #29230:
URL: https://github.com/apache/shardingsphere/pull/29230#discussion_r1408603319
##########
test/it/parser/src/main/resources/case/dml/insert.xml:
##########
@@ -2900,4 +2900,36 @@
</from>
</select>
</insert>
+ <insert sql-case-id="insert_into_my_temp_table_1">
Review Comment:
Where is the orginal sql?
##########
parser/sql/dialect/sqlserver/src/main/antlr4/imports/sqlserver/BaseRule.g4:
##########
@@ -154,6 +154,10 @@ tableName
: (owner DOT_)? name
;
+tempTableName
Review Comment:
What is the different between tableName and tempTableName?
##########
test/it/parser/src/main/resources/case/dml/insert.xml:
##########
@@ -2900,4 +2900,36 @@
</from>
</select>
</insert>
+ <insert sql-case-id="insert_into_my_temp_table_1">
+ <table name="#MyTempTable" start-index="12" stop-index="25" />
+ <values>
+ <value>
+ <assignment-value>
+ <literal-expression value="1" start-index="31"
stop-index="31" />
+ </assignment-value>
+ </value>
+ </values>
+ </insert>
+
+ <insert sql-case-id="insert_into_temp_table_2">
Review Comment:
Please rename sql-case-id to more meaningful name.
##########
test/it/parser/src/main/resources/case/dml/select-expression.xml:
##########
@@ -3125,4 +3125,51 @@
</expression-projection>
</projections>
</select>
+
+ <select sql-case-id="select_from_temporary_table_Test2Col_equals_x">
+ <projections start-index="7" stop-index="19">
+ <expression-projection start-index="7" stop-index="19"
text="Test2Col = x">
+ <expr>
+ <binary-operation-expression start-index="7"
stop-index="19">
+ <left>
+ <column name="Test2Col" start-index="7"
stop-index="13"/>
+ </left>
+ <operator>=</operator>
+ <right>
+ <column name="x" start-index="17" stop-index="18"/>
+ </right>
+ </binary-operation-expression>
+ </expr>
+ </expression-projection>
+ </projections>
+ <from>
+ <simple-table name="#t" start-index="23" stop-index="25">
Review Comment:
Please use `<simple-table><simple-table />` if it doesn't have child node.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
