TestBoost opened a new pull request, #2378: URL: https://github.com/apache/shardingsphere-elasticjob/pull/2378
Changes proposed in this pull request: - put `zkRegCenter.init();` and `zkRegCenter.close();` into the method body of `@BeforeAll` and `@AfterAll`. There are three tests in the test class `OneOffJobBootstrapTest`. However, these three tests are justing trying to use `zkRegCenter` to initialize some objects and they are not modifying `zkRegCenter`. - Besides, we searched for all the tests which contain `zkRegCenter.init();` and `zkRegCenter.close();`. All tests in the project `apache/shardingsphere-elasticjob` except `OneOffJobBootstrapTest` put `zkRegCenter.init();` and `zkRegCenter.close();` into the method body of `@BeforeAll` and `@AfterAll`. - The test runtime can jump from `3.489 s` to `2.403 s` after applying the changes when run on our machine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
