strongduanmu commented on code in PR #30526:
URL: https://github.com/apache/shardingsphere/pull/30526#discussion_r1527894357
##########
parser/sql/dialect/oracle/src/main/antlr4/imports/oracle/DDLStatement.g4:
##########
@@ -1030,7 +1030,7 @@ externalTableClause
;
externalTableDataProps
- : (DEFAULT DIRECTORY directoryName)? (ACCESS PARAMETERS
((opaqueFormatSpec) | USING CLOB subquery))? (LOCATION LP_ (directoryName
COLON_)? locationSpecifier (COMMA_ (directoryName COLON_)? locationSpecifier)+
RP_)?
+ : (DEFAULT DIRECTORY directoryName)? (ACCESS PARAMETERS ((opaqueFormatSpec
delimSpec )?|USING CLOB subquery))? (LOCATION LP_ (directoryName|(directoryName
COLON_)? locationSpecifier (COMMA_ (directoryName COLON_)? locationSpecifier)+)
RP_)?
Review Comment:
Please remove extra white space after `delimSpec`, and add white space for
`|`
##########
parser/sql/dialect/oracle/src/main/antlr4/imports/oracle/DDLStatement.g4:
##########
@@ -196,7 +196,7 @@ createDefinitionClause
createXMLTypeTableClause
: OF? XMLTYPE
- (LP_ (objectProperties) RP_)?
+ (LP_ (objectProperties) RP_)?
Review Comment:
Please remove extra white space.
##########
parser/sql/dialect/oracle/src/main/antlr4/imports/oracle/BaseRule.g4:
##########
@@ -2164,3 +2164,23 @@ dbUserProxy
dbUserProxyClauses
: (WITH ((ROLE (ALL EXCEPT)? roleName (COMMA_ roleName)*) | NO ROLES))?
(AUTHENTICATION REQUIRED | AUTHENTICATED USING PASSWORD)?
;
+
+delimSpec
+ : terminatedBySpec? optionallyEnclosedBySpec? lrtrimSpec?
+ ;
+
+terminatedBySpec
+ : TERMINATED BY (STRING_|WHITESPACE)
+ ;
+
+optionallyEnclosedBySpec
+ : OPTIONALLY? ENCLOSED BY STRING_ AND STRING_
+ ;
+
+lrtrimSpec
+ : LRTRIM
+ ;
+
Review Comment:
Please these useless blank lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
