zhaojinchao95 commented on code in PR #30587:
URL: https://github.com/apache/shardingsphere/pull/30587#discussion_r1535003482
##########
kernel/metadata/core/src/test/java/org/apache/shardingsphere/metadata/persist/MetaDataPersistServiceTest.java:
##########
@@ -66,4 +84,18 @@ private void setField(final String name, final Object value)
throws ReflectiveOp
void assertLoadDataSourceConfigurations() {
assertTrue(metaDataPersistService.loadDataSourceConfigurations("foo_db").isEmpty());
}
+
+ @Test
+ void testPersistGlobalRuleConfiguration() {
Review Comment:
The unit test not assert
##########
kernel/metadata/core/src/test/java/org/apache/shardingsphere/metadata/persist/MetaDataPersistServiceTest.java:
##########
@@ -66,4 +84,18 @@ private void setField(final String name, final Object value)
throws ReflectiveOp
void assertLoadDataSourceConfigurations() {
assertTrue(metaDataPersistService.loadDataSourceConfigurations("foo_db").isEmpty());
}
+
+ @Test
+ void testPersistGlobalRuleConfiguration() {
+ doNothing().when(globalRuleService).persist(anyCollection());
+ doNothing().when(propsService).persist(any());
+
metaDataPersistService.persistGlobalRuleConfiguration(Collections.emptyList(),
new Properties());
+ }
+
+ @Test
+ void testPersistConfigurations() {
Review Comment:
The unit test not assert
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
