menghaoranss commented on code in PR #32339:
URL: https://github.com/apache/shardingsphere/pull/32339#discussion_r1697817846
##########
proxy/bootstrap/src/main/java/org/apache/shardingsphere/proxy/Bootstrap.java:
##########
@@ -52,6 +54,7 @@ public static void main(final String[] args) throws
IOException, SQLException {
YamlProxyConfiguration yamlConfig =
ProxyConfigurationLoader.load(bootstrapArgs.getConfigurationPath());
int port = bootstrapArgs.getPort().orElseGet(() -> new
ConfigurationProperties(yamlConfig.getServerConfiguration().getProps()).getValue(ConfigurationPropertyKey.PROXY_DEFAULT_PORT));
List<String> addresses = bootstrapArgs.getAddresses();
+ checkPort(addresses, port);
Review Comment:
this method only solved the issue of port, if other unknown exceptions have
occurred at proxy.start(), the proxy will not exit, and the jobs or other
resources will not be released
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
