linghengqian commented on code in PR #32614:
URL: https://github.com/apache/shardingsphere/pull/32614#discussion_r1726707761


##########
pom.xml:
##########
@@ -970,25 +970,8 @@
             </activation>
             <properties>
                 <maven.compiler.release>8</maven.compiler.release>
+                <argLine>--add-opens java.base/java.lang=ALL-UNNAMED 
--add-opens java.base/java.lang.reflect=ALL-UNNAMED --add-opens 
java.base/sun.net=ALL-UNNAMED --add-opens 
java.base/java.net=ALL-UNNAMED</argLine>
             </properties>
-            <build>
-                <pluginManagement>
-                    <plugins>
-                        <plugin>
-                            <artifactId>maven-surefire-plugin</artifactId>
-                            <configuration>
-                                <argLine>--add-opens 
java.base/java.lang=ALL-UNNAMED --add-opens 
java.base/java.lang.reflect=ALL-UNNAMED --add-opens 
java.base/sun.net=ALL-UNNAMED --add-opens 
java.base/java.net=ALL-UNNAMED</argLine>
-                            </configuration>
-                        </plugin>
-                        <plugin>
-                            <artifactId>maven-failsafe-plugin</artifactId>
-                            <configuration>
-                                <argLine>--add-opens 
java.base/java.lang=ALL-UNNAMED --add-opens 
java.base/java.lang.reflect=ALL-UNNAMED --add-opens 
java.base/sun.net=ALL-UNNAMED --add-opens 
java.base/java.net=ALL-UNNAMED</argLine>
-                            </configuration>
-                        </plugin>
-                    </plugins>
-                </pluginManagement>
-            </build>

Review Comment:
   - Simply check 
https://github.com/apache/shardingsphere/actions/runs/10505123126/job/29102035924?pr=32614
 .
   ```shell
   java.lang.IllegalAccessError: class 
com.alibaba.dcm.internal.InetAddressCacheUtilCommons (in unnamed module 
@0x70b0b186) cannot access class sun.net.InetAddressCachePolicy (in module 
java.base) because module java.base does not export sun.net to unnamed module 
@0x70b0b186
        at 
com.alibaba.dcm.internal.InetAddressCacheUtilCommons.initFieldsOfInetAddressCachePolicy(InetAddressCacheUtilCommons.java:156)
        at 
com.alibaba.dcm.internal.InetAddressCacheUtilCommons.setCachePolicy0(InetAddressCacheUtilCommons.java:120)
        at 
com.alibaba.dcm.internal.InetAddressCacheUtilCommons.setDnsCachePolicy(InetAddressCacheUtilCommons.java:70)
        at 
com.alibaba.dcm.DnsCacheManipulator.setDnsCachePolicy(DnsCacheManipulator.java:311)
        at 
org.apache.shardingsphere.test.e2e.env.container.atomic.ITContainers.<init>(ITContainers.java:57)
        at 
org.apache.shardingsphere.test.e2e.transaction.framework.container.compose.BaseContainerComposer.<init>(BaseContainerComposer.java:30)
        at 
org.apache.shardingsphere.test.e2e.transaction.framework.container.compose.DockerContainerComposer.<init>(DockerContainerComposer.java:58)
        at 
org.apache.shardingsphere.test.e2e.transaction.engine.base.TransactionContainerComposer.initContainerComposer(TransactionContainerComposer.java:53)
        at 
org.apache.shardingsphere.test.e2e.transaction.engine.base.TransactionContainerComposer.<init>(TransactionContainerComposer.java:48)
        at 
org.apache.shardingsphere.test.e2e.transaction.engine.base.TransactionBaseE2EIT.assertTransaction(TransactionBaseE2EIT.java:100)
        at java.base/java.lang.reflect.Method.invoke(Method.java:580)
        at 
java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
        at 
java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:212)
        at 
java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:194)
        at 
java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:212)
        at 
java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
        at 
java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:212)
        at 
java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:212)
        at 
java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:212)
        at 
java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
        at 
java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:212)
        at 
java.base/java.util.LinkedList$LLSpliterator.forEachRemaining(LinkedList.java:1249)
        at 
java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:556)
        at 
java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:546)
        at 
java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151)
        at 
java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174)
        at 
java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:265)
        at 
java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:611)
        at 
java.base/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:291)
        at 
java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:212)
        at 
java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:212)
        at 
java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:212)
        at 
java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1709)
        at 
java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:556)
        at 
java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:546)
        at 
java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151)
        at 
java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174)
        at 
java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:265)
        at 
java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:611)
        at 
java.base/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:291)
        at 
java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1709)
        at 
java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:556)
        at 
java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:546)
        at 
java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151)
        at 
java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174)
        at 
java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:265)
        at 
java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:611)
        at java.base/java.util.ArrayList.forEach(ArrayList.java:1597)
        at java.base/java.util.ArrayList.forEach(ArrayList.java:1597)
   ```
   - This was introduced by #32491 . 
   - I tried to make the JVM arguments of `--add-opens 
java.base/sun.net=ALL-UNNAMED --add-opens java.base/java.net=ALL-UNNAMED` take 
effect globally, but it didn't work. 
   - @iamhucong , I wonder if there is something somewhere that tries to 
override `argLine`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to