This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 9eba36ee1dd Refactor InventoryDumper (#32693)
9eba36ee1dd is described below

commit 9eba36ee1ddf019247d84b92cd7cac698e4c86db
Author: Liang Zhang <[email protected]>
AuthorDate: Tue Aug 27 01:07:53 2024 +0800

    Refactor InventoryDumper (#32693)
---
 .../pipeline/core/ingest/dumper/inventory/InventoryDumper.java    | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git 
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/inventory/InventoryDumper.java
 
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/inventory/InventoryDumper.java
index 414d4820a7c..4f7872ff274 100644
--- 
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/inventory/InventoryDumper.java
+++ 
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/inventory/InventoryDumper.java
@@ -169,7 +169,7 @@ public final class InventoryDumper extends 
AbstractPipelineLifecycleRunnable imp
     private List<Record> dumpPageByPage(final Connection connection, final 
InventoryQueryParameter queryParam, final AtomicLong rowCount) throws 
SQLException {
         DatabaseType databaseType = 
dumperContext.getCommonContext().getDataSourceConfig().getDatabaseType();
         int batchSize = dumperContext.getBatchSize();
-        try (PreparedStatement preparedStatement = 
JDBCStreamQueryBuilder.build(databaseType, connection, 
buildInventoryDumpPageByPageSQL(queryParam), batchSize)) {
+        try (PreparedStatement preparedStatement = 
JDBCStreamQueryBuilder.build(databaseType, connection, 
buildDumpPageByPageSQL(queryParam), batchSize)) {
             runningStatement.set(preparedStatement);
             setParameters(preparedStatement, queryParam, false);
             try (ResultSet resultSet = preparedStatement.executeQuery()) {
@@ -246,7 +246,7 @@ public final class InventoryDumper extends 
AbstractPipelineLifecycleRunnable imp
         return result;
     }
     
-    private String buildInventoryDumpPageByPageSQL(final 
InventoryQueryParameter queryParam) {
+    private String buildDumpPageByPageSQL(final InventoryQueryParameter 
queryParam) {
         String schemaName = 
dumperContext.getCommonContext().getTableAndSchemaNameMapper().getSchemaName(dumperContext.getLogicTableName());
         PipelineColumnMetaData firstColumn = 
dumperContext.getUniqueKeyColumns().get(0);
         List<String> columnNames = dumperContext.getQueryColumnNames();
@@ -275,7 +275,7 @@ public final class InventoryDumper extends 
AbstractPipelineLifecycleRunnable imp
         if (null != dumperContext.getTransactionIsolation()) {
             
connection.setTransactionIsolation(dumperContext.getTransactionIsolation());
         }
-        try (PreparedStatement preparedStatement = 
JDBCStreamQueryBuilder.build(databaseType, connection, 
buildInventoryDumpSQLWithStreamingQuery(), batchSize)) {
+        try (PreparedStatement preparedStatement = 
JDBCStreamQueryBuilder.build(databaseType, connection, 
buildDumpSQLWithStreamingQuery(), batchSize)) {
             runningStatement.set(preparedStatement);
             PrimaryKeyIngestPosition<?> primaryPosition = 
(PrimaryKeyIngestPosition<?>) dumperContext.getCommonContext().getPosition();
             InventoryQueryParameter queryParam = 
InventoryQueryParameter.buildForRangeQuery(new 
QueryRange(primaryPosition.getBeginValue(), true, 
primaryPosition.getEndValue()));
@@ -310,7 +310,7 @@ public final class InventoryDumper extends 
AbstractPipelineLifecycleRunnable imp
         }
     }
     
-    private String buildInventoryDumpSQLWithStreamingQuery() {
+    private String buildDumpSQLWithStreamingQuery() {
         if (!Strings.isNullOrEmpty(dumperContext.getQuerySQL())) {
             return dumperContext.getQuerySQL();
         }

Reply via email to