RaigorJiang commented on code in PR #32755:
URL: https://github.com/apache/shardingsphere/pull/32755#discussion_r1740631993
##########
features/mask/distsql/handler/src/main/java/org/apache/shardingsphere/mask/distsql/handler/update/DropMaskRuleExecutor.java:
##########
@@ -57,14 +58,15 @@ public void checkBeforeUpdate(final DropMaskRuleStatement
sqlStatement) {
}
private void checkToBeDroppedMaskTableNames(final DropMaskRuleStatement
sqlStatement) {
- Collection<String> currentMaskTableNames =
rule.getConfiguration().getTables().stream().map(MaskTableRuleConfiguration::getName).collect(Collectors.toList());
+ Collection<String> currentMaskTableNames = new
CaseInsensitiveSet<>(rule.getConfiguration().getTables().stream().map(MaskTableRuleConfiguration::getName).collect(Collectors.toList()));
Review Comment:
We can directly collect into a set object
> collect(Collectors.toCollection(CaseInsensitiveSet::new))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
