This is an automated email from the ASF dual-hosted git repository. jianglongtao pushed a commit to branch fix-33341 in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
commit 01ff11066d7dd2c26c3efe308bc9ac77302e4b77 Author: RaigorJiang <[email protected]> AuthorDate: Tue Oct 22 13:56:54 2024 +0800 For apache #33341, remove available target check in StandardShardingStrategy --- .../route/strategy/type/standard/StandardShardingStrategy.java | 3 --- .../route/engine/type/standard/ShardingStandardRoutingEngineTest.java | 2 ++ 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/features/sharding/core/src/main/java/org/apache/shardingsphere/sharding/route/strategy/type/standard/StandardShardingStrategy.java b/features/sharding/core/src/main/java/org/apache/shardingsphere/sharding/route/strategy/type/standard/StandardShardingStrategy.java index d46fb4922cb..9bac8f42799 100644 --- a/features/sharding/core/src/main/java/org/apache/shardingsphere/sharding/route/strategy/type/standard/StandardShardingStrategy.java +++ b/features/sharding/core/src/main/java/org/apache/shardingsphere/sharding/route/strategy/type/standard/StandardShardingStrategy.java @@ -24,7 +24,6 @@ import org.apache.shardingsphere.infra.exception.core.ShardingSpherePrecondition import org.apache.shardingsphere.sharding.api.sharding.standard.PreciseShardingValue; import org.apache.shardingsphere.sharding.api.sharding.standard.RangeShardingValue; import org.apache.shardingsphere.sharding.api.sharding.standard.StandardShardingAlgorithm; -import org.apache.shardingsphere.sharding.exception.algorithm.ShardingRouteAlgorithmException; import org.apache.shardingsphere.sharding.exception.metadata.MissingRequiredShardingConfigurationException; import org.apache.shardingsphere.sharding.route.engine.condition.value.ListShardingConditionValue; import org.apache.shardingsphere.sharding.route.engine.condition.value.RangeShardingConditionValue; @@ -76,8 +75,6 @@ public final class StandardShardingStrategy implements ShardingStrategy { new PreciseShardingValue(shardingValue.getTableName(), shardingValue.getColumnName(), dataNodeInfo, each)); if (null != target && availableTargetNames.contains(target)) { result.add(target); - } else if (null != target && !availableTargetNames.contains(target)) { - throw new ShardingRouteAlgorithmException(target, availableTargetNames); } } return result; diff --git a/features/sharding/core/src/test/java/org/apache/shardingsphere/sharding/route/engine/type/standard/ShardingStandardRoutingEngineTest.java b/features/sharding/core/src/test/java/org/apache/shardingsphere/sharding/route/engine/type/standard/ShardingStandardRoutingEngineTest.java index c468534476b..544048171c8 100644 --- a/features/sharding/core/src/test/java/org/apache/shardingsphere/sharding/route/engine/type/standard/ShardingStandardRoutingEngineTest.java +++ b/features/sharding/core/src/test/java/org/apache/shardingsphere/sharding/route/engine/type/standard/ShardingStandardRoutingEngineTest.java @@ -28,6 +28,7 @@ import org.apache.shardingsphere.sharding.route.engine.condition.ShardingConditi import org.apache.shardingsphere.sharding.route.engine.fixture.ShardingRoutingEngineFixtureBuilder; import org.apache.shardingsphere.sharding.rule.ShardingRule; import org.junit.jupiter.api.AfterEach; +import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.Test; import java.util.ArrayList; @@ -87,6 +88,7 @@ class ShardingStandardRoutingEngineTest { assertThat(routeUnits.get(0).getTableMappers().iterator().next().getLogicName(), is("t_order")); } + @Disabled("Check removed in StandardShardingStrategy") @Test void assertRouteByErrorShardingTableStrategy() { ShardingStandardRoutingEngine standardRoutingEngine = createShardingStandardRoutingEngine("t_order", ShardingRoutingEngineFixtureBuilder.createErrorShardingConditions("t_order"),
