This is an automated email from the ASF dual-hosted git repository.
zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 1a494de262b Remove useless PrimaryKeyIngestPosition.convert() (#33353)
1a494de262b is described below
commit 1a494de262b8acea8366f996a787eca318f4cb16
Author: Liang Zhang <[email protected]>
AuthorDate: Wed Oct 23 00:01:33 2024 +0800
Remove useless PrimaryKeyIngestPosition.convert() (#33353)
---
.../core/ingest/position/type/pk/PrimaryKeyIngestPosition.java | 7 -------
.../position/type/pk/type/IntegerPrimaryKeyIngestPosition.java | 5 -----
.../position/type/pk/type/StringPrimaryKeyIngestPosition.java | 5 -----
.../ingest/position/type/pk/type/UnsupportedKeyIngestPosition.java | 5 -----
4 files changed, 22 deletions(-)
diff --git
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/position/type/pk/PrimaryKeyIngestPosition.java
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/position/type/pk/PrimaryKeyIngestPosition.java
index 503594a4b29..1a07b3fdf61 100644
---
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/position/type/pk/PrimaryKeyIngestPosition.java
+++
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/position/type/pk/PrimaryKeyIngestPosition.java
@@ -40,13 +40,6 @@ public interface PrimaryKeyIngestPosition<T> extends
IngestPosition {
*/
T getEndValue();
- /**
- * Convert value.
- * @param value value to be converted
- * @return converted value
- */
- T convert(String value);
-
/**
* Get type.
*
diff --git
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/position/type/pk/type/IntegerPrimaryKeyIngestPosition.java
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/position/type/pk/type/IntegerPrimaryKeyIngestPosition.java
index 65fe71fd221..f235759e42c 100644
---
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/position/type/pk/type/IntegerPrimaryKeyIngestPosition.java
+++
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/position/type/pk/type/IntegerPrimaryKeyIngestPosition.java
@@ -43,11 +43,6 @@ public final class IntegerPrimaryKeyIngestPosition
implements PrimaryKeyIngestPo
return endValue;
}
- @Override
- public Long convert(final String value) {
- return Long.parseLong(value);
- }
-
@Override
public char getType() {
return 'i';
diff --git
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/position/type/pk/type/StringPrimaryKeyIngestPosition.java
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/position/type/pk/type/StringPrimaryKeyIngestPosition.java
index a10017fd3f0..96cf79ae708 100644
---
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/position/type/pk/type/StringPrimaryKeyIngestPosition.java
+++
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/position/type/pk/type/StringPrimaryKeyIngestPosition.java
@@ -36,11 +36,6 @@ public final class StringPrimaryKeyIngestPosition implements
PrimaryKeyIngestPos
this.endValue = Strings.emptyToNull(endValue);
}
- @Override
- public String convert(final String value) {
- return value;
- }
-
@Override
public char getType() {
return 's';
diff --git
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/position/type/pk/type/UnsupportedKeyIngestPosition.java
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/position/type/pk/type/UnsupportedKeyIngestPosition.java
index d8563ac1e41..8406c07518d 100644
---
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/position/type/pk/type/UnsupportedKeyIngestPosition.java
+++
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/position/type/pk/type/UnsupportedKeyIngestPosition.java
@@ -34,11 +34,6 @@ public final class UnsupportedKeyIngestPosition implements
PrimaryKeyIngestPosit
return null;
}
- @Override
- public Void convert(final String value) {
- throw new UnsupportedOperationException("");
- }
-
@Override
public char getType() {
return 'u';
