danigiri opened a new pull request, #33571: URL: https://github.com/apache/shardingsphere/pull/33571
Continuing with Doris parsing support. In this case adding support for `EXTRACT_URL_PARAMETER` see https://doris.apache.org/docs/sql-manual/sql-functions/string-functions/extract-url-parameter No equivalent mysql function i could find. Continues to address #31508 ### Changes proposed in this pull request: - added test - Marked // DORIS ADDED BEGIN|END - added parser g4 stuff, within `extractUrlParameterFunction` - added visitor logic as needed - ran spotless - ran (though will check again once committed and do a full test) ``` cd test/it/parser/ mvn -DskipTests=true generate-sources compile install -q cd parser/sql/dialect/doris/ mvn test -Dit.test=InternalDorisParserIT ``` ### Next - Add change to release notes - Run full tests on test machine (running) ### Question - do we collapse two consecutive changes? So ``` // DORIS ADDED END // DORIS ADDED BEGIN ``` would be ``` ``` and have a final terminating `// DORIS ADDED END` at the end --- Before committing this PR, I'm sure that I have checked the following options: - [✅] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project. - [✅] I have self-reviewed the commit code. - [✅] I have (or in comment I request) added corresponding labels for the pull request. - [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`. - [ ] I have made corresponding changes to the documentation. - [✅] I have added corresponding unit tests for my changes. - [✅] mvn spotless:apply -Pcheck - [✅] mvn test -Dit.test=InternalDorisParserIT in shardingsphere/parser/sql/dialect/doris (need to specify it.test) - [✅] Executed test case in Doris v2.1.6 – `SELECT EXTRACT_URL_PARAMETER('http://foo.com/?bar=baz','bar')` ``` +---------------------------------------------------------+ | extract_url_parameter('http://foo.com/?bar=baz', 'bar') | +---------------------------------------------------------+ | baz | +---------------------------------------------------------+ 1 row in set (0.31 sec) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
