(shardingsphere) branch master updated: Remove useless ShardingSphereTable.putColumn (#33787)

[zhangliang]

This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new fb882f20587 Remove useless ShardingSphereTable.putColumn (#33787)
fb882f20587 is described below

commit fb882f20587b5b2b79dedfd8bafa102734dc7718
Author: Liang Zhang <zhangli...@apache.org>
AuthorDate: Mon Nov 25 01:11:21 2024 +0800

    Remove useless ShardingSphereTable.putColumn (#33787)
---
 .../database/schema/model/ShardingSphereSchema.java   |  2 +-
 .../database/schema/model/ShardingSphereTable.java    | 19 +++----------------
 2 files changed, 4 insertions(+), 17 deletions(-)

diff --git 
a/infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/database/schema/model/ShardingSphereSchema.java
 
b/infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/database/schema/model/ShardingSphereSchema.java
index 3d748287706..247aa8c5371 100644
--- 
a/infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/database/schema/model/ShardingSphereSchema.java
+++ 
b/infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/database/schema/model/ShardingSphereSchema.java
@@ -209,7 +209,7 @@ public final class ShardingSphereSchema {
      * @return visible column names and indexes
      */
     public Map<String, Integer> getVisibleColumnNamesAndIndexes(final String 
tableName) {
-        return containsTable(tableName) ? 
getTable(tableName).getVisibleColumnsAndIndexes() : Collections.emptyMap();
+        return containsTable(tableName) ? 
getTable(tableName).getVisibleColumnsAndIndexMap() : Collections.emptyMap();
     }
     
     /**
diff --git 
a/infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/database/schema/model/ShardingSphereTable.java
 
b/infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/database/schema/model/ShardingSphereTable.java
index d94284e7e44..31d6a3a6f76 100644
--- 
a/infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/database/schema/model/ShardingSphereTable.java
+++ 
b/infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/database/schema/model/ShardingSphereTable.java
@@ -52,7 +52,7 @@ public final class ShardingSphereTable {
     
     private final List<String> visibleColumns = new ArrayList<>();
     
-    private final Map<String, Integer> visibleColumnsAndIndexes = new 
CaseInsensitiveMap<>();
+    private final Map<String, Integer> visibleColumnsAndIndexMap = new 
CaseInsensitiveMap<>();
     
     private final List<String> primaryKeyColumns = new ArrayList<>();
     
@@ -64,11 +64,7 @@ public final class ShardingSphereTable {
     
     public ShardingSphereTable(final String name, final 
Collection<ShardingSphereColumn> columns,
                                final Collection<ShardingSphereIndex> indexes, 
final Collection<ShardingSphereConstraint> constraints) {
-        this.name = name;
-        this.columns = createColumns(columns);
-        this.indexes = createIndexes(indexes);
-        this.constraints = createConstraints(constraints);
-        type = TableType.TABLE;
+        this(name, columns, indexes, constraints, TableType.TABLE);
     }
     
     public ShardingSphereTable(final String name, final 
Collection<ShardingSphereColumn> columns,
@@ -91,7 +87,7 @@ public final class ShardingSphereTable {
             }
             if (each.isVisible()) {
                 visibleColumns.add(each.getName());
-                visibleColumnsAndIndexes.put(each.getName(), index++);
+                visibleColumnsAndIndexMap.put(each.getName(), index++);
             }
         }
         return result;
@@ -113,15 +109,6 @@ public final class ShardingSphereTable {
         return result;
     }
     
-    /**
-     * Put column meta data.
-     *
-     * @param column column meta data
-     */
-    public void putColumn(final ShardingSphereColumn column) {
-        columns.put(new ShardingSphereMetaDataIdentifier(column.getName()), 
column);
-    }
-    
     /**
      * Get column meta data via column name.
      *