linghengqian commented on issue #33782: URL: https://github.com/apache/shardingsphere/issues/33782#issuecomment-2527036189
- If you need to support a new version of Firebird, you only need to implement the SPI of https://github.com/testcontainers/testcontainers-java/blob/main/modules/jdbc/src/main/java/org/testcontainers/containers/JdbcDatabaseContainerProvider.java in the downstream project. - There are quite a few integration modules in testcontainers that only support old versions of databases, including clickhouse in https://github.com/testcontainers/testcontainers-java/issues/8736 and presto in https://github.com/testcontainers/testcontainers-java/issues/8657 . Most downstream users actually implement `org.testcontainers.containers.JdbcDatabaseContainerProvider` themselves. - Shardingsphere actually only requires that these `jdbc:tc:xxx:` prefixes have a corresponding OSS Maven module to facilitate further integration testing. I don't think it is necessary to try to wait for these Maven modules to update support for new versions of the database. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
