(shardingsphere) branch master updated: Fix sonar issue on ShardingRouteEngineFactory (#34172)

[zhangliang]

This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new e95517caee2 Fix sonar issue on ShardingRouteEngineFactory (#34172)
e95517caee2 is described below

commit e95517caee239fc813d22d8b39512dc1938c940c
Author: Liang Zhang <zhangli...@apache.org>
AuthorDate: Fri Dec 27 00:03:50 2024 +0800

    Fix sonar issue on ShardingRouteEngineFactory (#34172)
---
 .../sharding/route/engine/type/ShardingRouteEngineFactory.java    | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git 
a/features/sharding/core/src/main/java/org/apache/shardingsphere/sharding/route/engine/type/ShardingRouteEngineFactory.java
 
b/features/sharding/core/src/main/java/org/apache/shardingsphere/sharding/route/engine/type/ShardingRouteEngineFactory.java
index 49de41137a3..0ed4d444f44 100644
--- 
a/features/sharding/core/src/main/java/org/apache/shardingsphere/sharding/route/engine/type/ShardingRouteEngineFactory.java
+++ 
b/features/sharding/core/src/main/java/org/apache/shardingsphere/sharding/route/engine/type/ShardingRouteEngineFactory.java
@@ -74,7 +74,7 @@ public final class ShardingRouteEngineFactory {
         SQLStatement sqlStatement = sqlStatementContext.getSqlStatement();
         if (sqlStatement instanceof DDLStatement) {
             return sqlStatementContext instanceof CursorAvailable
-                    ? getCursorRouteEngine(rule, database, 
sqlStatementContext, queryContext.getHintValueContext(), shardingConditions, 
logicTableNames, props)
+                    ? getCursorRouteEngine(rule, sqlStatementContext, 
queryContext.getHintValueContext(), shardingConditions, logicTableNames, props)
                     : getDDLRouteEngine(database, sqlStatementContext, 
logicTableNames);
         }
         if (sqlStatement instanceof DALStatement) {
@@ -83,7 +83,7 @@ public final class ShardingRouteEngineFactory {
         if (sqlStatement instanceof DCLStatement) {
             return getDCLRouteEngine(database, sqlStatementContext, 
logicTableNames);
         }
-        return getDQLRouteEngine(rule, database, sqlStatementContext, 
queryContext, shardingConditions, logicTableNames, props);
+        return getDQLRouteEngine(rule, sqlStatementContext, queryContext, 
shardingConditions, logicTableNames, props);
     }
     
     private static ShardingRouteEngine getDDLRouteEngine(final 
ShardingSphereDatabase database, final SQLStatementContext sqlStatementContext, 
final Collection<String> logicTableNames) {
@@ -95,7 +95,7 @@ public final class ShardingRouteEngineFactory {
         return new ShardingTableBroadcastRouteEngine(database, 
sqlStatementContext, logicTableNames);
     }
     
-    private static ShardingRouteEngine getCursorRouteEngine(final ShardingRule 
rule, final ShardingSphereDatabase database, final SQLStatementContext 
sqlStatementContext,
+    private static ShardingRouteEngine getCursorRouteEngine(final ShardingRule 
rule, final SQLStatementContext sqlStatementContext,
                                                             final 
HintValueContext hintValueContext, final ShardingConditions shardingConditions, 
final Collection<String> logicTableNames,
                                                             final 
ConfigurationProperties props) {
         boolean allBindingTables = logicTableNames.size() > 1 && 
rule.isBindingTablesUseShardingColumnsJoin(sqlStatementContext, 
logicTableNames);
@@ -128,7 +128,7 @@ public final class ShardingRouteEngineFactory {
         return false;
     }
     
-    private static ShardingRouteEngine getDQLRouteEngine(final ShardingRule 
rule, final ShardingSphereDatabase database, final SQLStatementContext 
sqlStatementContext,
+    private static ShardingRouteEngine getDQLRouteEngine(final ShardingRule 
rule, final SQLStatementContext sqlStatementContext,
                                                          final QueryContext 
queryContext, final ShardingConditions shardingConditions, final 
Collection<String> logicTableNames,
                                                          final 
ConfigurationProperties props) {
         Collection<String> tableNames = sqlStatementContext instanceof 
TableAvailable ? ((TableAvailable) 
sqlStatementContext).getTablesContext().getTableNames() : 
Collections.emptyList();