Yash-cor commented on code in PR #34163:
URL: https://github.com/apache/shardingsphere/pull/34163#discussion_r1899948100
##########
infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/engine/statement/SQLStatementBinderContext.java:
##########
@@ -47,6 +49,8 @@ public final class SQLStatementBinderContext {
private final SQLStatement sqlStatement;
+ private final Set<CaseInsensitiveString>
commonTableExpressionsSegmentsUniqueAliases = new HashSet<>();
Review Comment:
Now I am using `Collection<String>
commonTableExpressionsSegmentsUniqueAliases = new CaseInsensitiveSet<>();`
CaseInsensitiveSet<String> will be better as it ease the overhead of
creating the object in case of Set<CaseInsensitiveString>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
