This is an automated email from the ASF dual-hosted git repository.
zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new c2fcf41a51b Add ShardingSphereDefaultStatisticsBuilderTest (#34375)
c2fcf41a51b is described below
commit c2fcf41a51bf698b104b11e05187cbbf5db89c79
Author: Liang Zhang <[email protected]>
AuthorDate: Thu Jan 16 23:20:56 2025 +0800
Add ShardingSphereDefaultStatisticsBuilderTest (#34375)
---
.../MySQLShardingSphereStatisticsBuilder.java | 1 -
.../PostgreSQLShardingSphereStatisticsBuilder.java | 1 -
...hardingSphereDefaultStatisticsBuilderTest.java} | 29 ++++++++++++----------
3 files changed, 16 insertions(+), 15 deletions(-)
diff --git
a/infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/statistics/builder/dialect/MySQLShardingSphereStatisticsBuilder.java
b/infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/statistics/builder/dialect/MySQLShardingSphereStatisticsBuilder.java
index f09d9436872..825227ce027 100644
---
a/infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/statistics/builder/dialect/MySQLShardingSphereStatisticsBuilder.java
+++
b/infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/statistics/builder/dialect/MySQLShardingSphereStatisticsBuilder.java
@@ -25,7 +25,6 @@ import
org.apache.shardingsphere.infra.metadata.statistics.builder.ShardingSpher
/**
* ShardingSphere statistics builder for MySQL.
*/
-
public final class MySQLShardingSphereStatisticsBuilder implements
ShardingSphereStatisticsBuilder {
@Override
diff --git
a/infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/statistics/builder/dialect/PostgreSQLShardingSphereStatisticsBuilder.java
b/infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/statistics/builder/dialect/PostgreSQLShardingSphereStatisticsBuilder.java
index 192064e839d..1b419146873 100644
---
a/infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/statistics/builder/dialect/PostgreSQLShardingSphereStatisticsBuilder.java
+++
b/infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/statistics/builder/dialect/PostgreSQLShardingSphereStatisticsBuilder.java
@@ -35,7 +35,6 @@ import java.util.Map.Entry;
/**
* ShardingSphere statistics builder for PostgreSQL.
*/
-
public final class PostgreSQLShardingSphereStatisticsBuilder implements
ShardingSphereStatisticsBuilder {
private static final Map<String, Collection<String>>
INIT_DATA_SCHEMA_TABLES = new LinkedHashMap<>();
diff --git
a/infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/statistics/builder/dialect/MySQLShardingSphereStatisticsBuilder.java
b/infra/common/src/test/java/org/apache/shardingsphere/infra/metadata/statistics/builder/ShardingSphereDefaultStatisticsBuilderTest.java
similarity index 53%
copy from
infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/statistics/builder/dialect/MySQLShardingSphereStatisticsBuilder.java
copy to
infra/common/src/test/java/org/apache/shardingsphere/infra/metadata/statistics/builder/ShardingSphereDefaultStatisticsBuilderTest.java
index f09d9436872..a417a497831 100644
---
a/infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/statistics/builder/dialect/MySQLShardingSphereStatisticsBuilder.java
+++
b/infra/common/src/test/java/org/apache/shardingsphere/infra/metadata/statistics/builder/ShardingSphereDefaultStatisticsBuilderTest.java
@@ -15,26 +15,29 @@
* limitations under the License.
*/
-package org.apache.shardingsphere.infra.metadata.statistics.builder.dialect;
+package org.apache.shardingsphere.infra.metadata.statistics.builder;
import
org.apache.shardingsphere.infra.metadata.database.ShardingSphereDatabase;
import
org.apache.shardingsphere.infra.metadata.statistics.ShardingSphereDatabaseData;
-import
org.apache.shardingsphere.infra.metadata.statistics.builder.ShardingSphereDefaultStatisticsBuilder;
-import
org.apache.shardingsphere.infra.metadata.statistics.builder.ShardingSphereStatisticsBuilder;
+import org.junit.jupiter.api.Test;
-/**
- * ShardingSphere statistics builder for MySQL.
- */
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
-public final class MySQLShardingSphereStatisticsBuilder implements
ShardingSphereStatisticsBuilder {
+class ShardingSphereDefaultStatisticsBuilderTest {
- @Override
- public ShardingSphereDatabaseData build(final ShardingSphereDatabase
database) {
- return new ShardingSphereDefaultStatisticsBuilder().build(database);
+ @Test
+ void assertBuild() {
+ ShardingSphereDatabaseData databaseData = new
ShardingSphereDefaultStatisticsBuilder().build(mockDatabase());
+ assertTrue(databaseData.getSchemaData().containsKey("shardingsphere"));
+
assertTrue(databaseData.getSchemaData().get("shardingsphere").getTableData().containsKey("cluster_information"));
+
assertTrue(databaseData.getSchemaData().get("shardingsphere").getTableData().containsKey("sharding_table_statistics"));
}
- @Override
- public String getDatabaseType() {
- return "MySQL";
+ private ShardingSphereDatabase mockDatabase() {
+ ShardingSphereDatabase result = mock(ShardingSphereDatabase.class);
+ when(result.containsSchema("shardingsphere")).thenReturn(true);
+ return result;
}
}