strongduanmu commented on code in PR #34425:
URL: https://github.com/apache/shardingsphere/pull/34425#discussion_r1925135199
##########
parser/sql/statement/type/postgresql/src/main/java/org/apache/shardingsphere/sql/parser/statement/postgresql/dml/PostgreSQLInsertStatement.java:
##########
@@ -34,7 +34,7 @@ public final class PostgreSQLInsertStatement extends
InsertStatement implements
private WithSegment withSegment;
- private OnDuplicateKeyColumnsSegment onDuplicateKeyColumnsSegment;
+ private OnDuplicateKeyColumnsSegment onDuplicateKeyColumns;
Review Comment:
Can you check openGauss insert statement? Since they are same database
dialect.
##########
parser/sql/statement/type/postgresql/src/main/java/org/apache/shardingsphere/sql/parser/statement/postgresql/dml/PostgreSQLInsertStatement.java:
##########
@@ -45,7 +45,7 @@ public Optional<WithSegment> getWithSegment() {
@Override
public Optional<OnDuplicateKeyColumnsSegment> getOnDuplicateKeyColumns() {
- return Optional.ofNullable(onDuplicateKeyColumnsSegment);
+ return Optional.ofNullable(onDuplicateKeyColumns);
Review Comment:
Besides, you need add sql parser test for this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
