gdut-yy commented on issue #34444: URL: https://github.com/apache/shardingsphere/issues/34444#issuecomment-2609830369
@terrymanu Of course, it's easy to fix this problem by adding a judgment branch of `java.time.Duration` to `DataSourcePoolReflection#setField` But I don't think this will solve the problem fundamentally, it can't exhaust all scenarios, other parameter types of other DataSources may have similar problems, need to see if there is a more elegant design pattern? Or, should dbcp2 not have the input parameter type `java.time.Duration`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
