This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new f0880fd8b71 Fixes exception thrown if renamed schema name missed on 
AlterSchemaPushDownMetaDataRefresher (#34465)
f0880fd8b71 is described below

commit f0880fd8b71ccae48acd570e6c8820c31edf56cb
Author: Liang Zhang <[email protected]>
AuthorDate: Fri Jan 24 15:34:31 2025 +0800

    Fixes exception thrown if renamed schema name missed on 
AlterSchemaPushDownMetaDataRefresher (#34465)
---
 .../type/schema/AlterSchemaPushDownMetaDataRefresher.java         | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git 
a/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/pushdown/type/schema/AlterSchemaPushDownMetaDataRefresher.java
 
b/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/pushdown/type/schema/AlterSchemaPushDownMetaDataRefresher.java
index 5ff9832acf0..f8818371730 100644
--- 
a/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/pushdown/type/schema/AlterSchemaPushDownMetaDataRefresher.java
+++ 
b/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/pushdown/type/schema/AlterSchemaPushDownMetaDataRefresher.java
@@ -17,7 +17,6 @@
 
 package 
org.apache.shardingsphere.mode.metadata.refresher.metadata.pushdown.type.schema;
 
-import com.google.common.base.Preconditions;
 import org.apache.shardingsphere.infra.config.props.ConfigurationProperties;
 import org.apache.shardingsphere.infra.database.core.type.DatabaseType;
 import 
org.apache.shardingsphere.infra.metadata.database.ShardingSphereDatabase;
@@ -39,9 +38,10 @@ public final class AlterSchemaPushDownMetaDataRefresher 
implements PushDownMetaD
     public void refresh(final MetaDataManagerPersistService 
metaDataManagerPersistService, final ShardingSphereDatabase database, final 
Collection<String> logicDataSourceNames,
                         final String schemaName, final DatabaseType 
databaseType, final AlterSchemaStatement sqlStatement, final 
ConfigurationProperties props) throws SQLException {
         Optional<String> renameSchemaName = 
sqlStatement.getRenameSchema().map(optional -> 
optional.getValue().toLowerCase());
-        Preconditions.checkArgument(renameSchemaName.isPresent(), "The renamed 
schema is not exist of schema '%s'.", schemaName);
-        metaDataManagerPersistService.alterSchema(new 
AlterSchemaPOJO(database.getName(), 
sqlStatement.getSchemaName().getValue().toLowerCase(),
-                renameSchemaName.get(), logicDataSourceNames));
+        if (!renameSchemaName.isPresent()) {
+            return;
+        }
+        metaDataManagerPersistService.alterSchema(new 
AlterSchemaPOJO(database.getName(), 
sqlStatement.getSchemaName().getValue().toLowerCase(), renameSchemaName.get(), 
logicDataSourceNames));
     }
     
     @Override

Reply via email to