jingshanglu commented on a change in pull request #5179: fix support for test
of some pagination
URL:
https://github.com/apache/incubator-shardingsphere/pull/5179#discussion_r408743739
##########
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/java/org/apache/shardingsphere/sql/parser/integrate/asserts/segment/table/TableFactorAssert.java
##########
@@ -43,8 +43,10 @@
* @param expected expected TableFactor
*/
public static void assertIs(final SQLCaseAssertContext assertContext,
final TableFactorSegment actual, final ExpectedTableFactor expected) {
- if (null != actual.getTable() && actual.getTable() instanceof
SimpleTableSegment) {
- TableAssert.assertIs(assertContext, (SimpleTableSegment)
actual.getTable(), expected.getTable());
+ if (null != actual.getTable()) {
+ if (actual.getTable() instanceof SimpleTableSegment) {
+ TableAssert.assertIs(assertContext, (SimpleTableSegment)
actual.getTable(), expected.getTable());
+ }
Review comment:
This change is for future subquery testing，if table is subqueryTable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
