This is an automated email from the ASF dual-hosted git repository.
zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 643e9494526 Refactor ViewMetadataNodePath (#34751)
643e9494526 is described below
commit 643e9494526e7338a97f80e2599c29b5b8755083
Author: Liang Zhang <[email protected]>
AuthorDate: Sun Feb 23 00:14:52 2025 +0800
Refactor ViewMetadataNodePath (#34751)
---
.../mode/node/path/metadata/database/ViewMetadataNodePath.java | 2 +-
.../mode/node/path/metadata/database/TableMetadataNodePathTest.java | 1 +
.../mode/node/path/metadata/database/ViewMetadataNodePathTest.java | 5 +----
3 files changed, 3 insertions(+), 5 deletions(-)
diff --git
a/mode/node/src/main/java/org/apache/shardingsphere/mode/node/path/metadata/database/ViewMetadataNodePath.java
b/mode/node/src/main/java/org/apache/shardingsphere/mode/node/path/metadata/database/ViewMetadataNodePath.java
index da18461de8b..273cedbe5ab 100644
---
a/mode/node/src/main/java/org/apache/shardingsphere/mode/node/path/metadata/database/ViewMetadataNodePath.java
+++
b/mode/node/src/main/java/org/apache/shardingsphere/mode/node/path/metadata/database/ViewMetadataNodePath.java
@@ -48,6 +48,6 @@ public final class ViewMetadataNodePath implements NodePath {
* @return created view search criteria
*/
public static NodePathSearchCriteria createViewSearchCriteria() {
- return new NodePathSearchCriteria(new ViewMetadataNodePath(), false,
true, 3);
+ return new NodePathSearchCriteria(new ViewMetadataNodePath(), false,
false, 3);
}
}
diff --git
a/mode/node/src/test/java/org/apache/shardingsphere/mode/node/path/metadata/database/TableMetadataNodePathTest.java
b/mode/node/src/test/java/org/apache/shardingsphere/mode/node/path/metadata/database/TableMetadataNodePathTest.java
index a5fee2e4465..056eb929daf 100644
---
a/mode/node/src/test/java/org/apache/shardingsphere/mode/node/path/metadata/database/TableMetadataNodePathTest.java
+++
b/mode/node/src/test/java/org/apache/shardingsphere/mode/node/path/metadata/database/TableMetadataNodePathTest.java
@@ -66,5 +66,6 @@ class TableMetadataNodePathTest {
assertThat(NodePathSearcher.find("/metadata/foo_db/schemas/foo_schema/tables/foo_tbl",
TableMetadataNodePath.createTableSearchCriteria()),
is(Optional.of("foo_tbl")));
assertFalse(NodePathSearcher.find("/xxx/foo_db/schemas/foo_schema/tables/foo_tbl",
TableMetadataNodePath.createTableSearchCriteria()).isPresent());
assertTrue(NodePathSearcher.isMatchedPath("/metadata/foo_db/schemas/foo_schema/tables/foo_tbl",
TableMetadataNodePath.createTableSearchCriteria()));
+
assertFalse(NodePathSearcher.isMatchedPath("/metadata/foo_db/schemas/foo_schema/tables/foo_tbl/versions/0",
TableMetadataNodePath.createTableSearchCriteria()));
}
}
diff --git
a/mode/node/src/test/java/org/apache/shardingsphere/mode/node/path/metadata/database/ViewMetadataNodePathTest.java
b/mode/node/src/test/java/org/apache/shardingsphere/mode/node/path/metadata/database/ViewMetadataNodePathTest.java
index 0d17c0b6b5a..1fd72575500 100644
---
a/mode/node/src/test/java/org/apache/shardingsphere/mode/node/path/metadata/database/ViewMetadataNodePathTest.java
+++
b/mode/node/src/test/java/org/apache/shardingsphere/mode/node/path/metadata/database/ViewMetadataNodePathTest.java
@@ -51,10 +51,7 @@ class ViewMetadataNodePathTest {
void assertCreateViewSearchCriteria() {
assertThat(NodePathSearcher.find("/metadata/foo_db/schemas/foo_schema/views/foo_view",
ViewMetadataNodePath.createViewSearchCriteria()), is(Optional.of("foo_view")));
assertFalse(NodePathSearcher.find("/xxx/foo_db/schemas/foo_schema/views/foo_view",
ViewMetadataNodePath.createViewSearchCriteria()).isPresent());
- }
-
- @Test
- void assertIsMatchedPath() {
assertTrue(NodePathSearcher.isMatchedPath("/metadata/foo_db/schemas/foo_schema/views/foo_view",
ViewMetadataNodePath.createViewSearchCriteria()));
+
assertFalse(NodePathSearcher.isMatchedPath("/metadata/foo_db/schemas/foo_schema/views/foo_view/versions/0",
ViewMetadataNodePath.createViewSearchCriteria()));
}
}