(shardingsphere) branch master updated: Fix sonar issue on ClusterMetaDataManagerPersistServiceTest (#34987)

[zhangliang]

This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new f5b86a026a3 Fix sonar issue on 
ClusterMetaDataManagerPersistServiceTest (#34987)
f5b86a026a3 is described below

commit f5b86a026a3776e40cf42a2d3e31f25533db7eba
Author: Liang Zhang <zhangli...@apache.org>
AuthorDate: Fri Mar 14 10:25:00 2025 +0800

    Fix sonar issue on ClusterMetaDataManagerPersistServiceTest (#34987)
---
 .../service/ClusterMetaDataManagerPersistServiceTest.java     | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git 
a/mode/type/cluster/core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/persist/service/ClusterMetaDataManagerPersistServiceTest.java
 
b/mode/type/cluster/core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/persist/service/ClusterMetaDataManagerPersistServiceTest.java
index 3b110e80314..7a6f4388dad 100644
--- 
a/mode/type/cluster/core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/persist/service/ClusterMetaDataManagerPersistServiceTest.java
+++ 
b/mode/type/cluster/core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/persist/service/ClusterMetaDataManagerPersistServiceTest.java
@@ -23,8 +23,8 @@ import 
org.apache.shardingsphere.infra.metadata.database.ShardingSphereDatabase;
 import org.apache.shardingsphere.infra.metadata.database.rule.RuleMetaData;
 import 
org.apache.shardingsphere.infra.metadata.database.schema.model.ShardingSphereSchema;
 import 
org.apache.shardingsphere.infra.metadata.database.schema.model.ShardingSphereTable;
-import 
org.apache.shardingsphere.mode.manager.cluster.persist.coordinator.database.ClusterDatabaseListenerPersistCoordinator;
 import 
org.apache.shardingsphere.mode.manager.cluster.persist.coordinator.database.ClusterDatabaseListenerCoordinatorType;
+import 
org.apache.shardingsphere.mode.manager.cluster.persist.coordinator.database.ClusterDatabaseListenerPersistCoordinator;
 import org.apache.shardingsphere.mode.metadata.manager.MetaDataContextManager;
 import org.apache.shardingsphere.mode.metadata.persist.MetaDataPersistFacade;
 import org.apache.shardingsphere.mode.spi.repository.PersistRepository;
@@ -40,7 +40,6 @@ import org.mockito.Mock;
 import org.mockito.internal.configuration.plugins.Plugins;
 import org.mockito.junit.jupiter.MockitoExtension;
 
-import java.sql.SQLException;
 import java.util.Collections;
 import java.util.Properties;
 
@@ -142,14 +141,14 @@ class ClusterMetaDataManagerPersistServiceTest {
     }
     
     @Test
-    void assertAlterNullRuleConfiguration() throws SQLException {
+    void assertAlterNullRuleConfiguration() {
         metaDataManagerPersistService.alterRuleConfiguration(new 
ShardingSphereDatabase("foo_db", mock(), mock(), mock(), 
Collections.emptyList()), null);
         verify(metaDataPersistFacade.getDatabaseRuleService(), 
times(0)).persist(eq("foo_db"), any());
     }
     
     @Test
     @Disabled
-    void assertAlterRuleConfiguration() throws SQLException {
+    void assertAlterRuleConfiguration() {
         RuleConfiguration ruleConfig = new SingleRuleConfiguration();
         
when(metaDataContextManager.getMetaDataContexts().getMetaData().getDatabase("foo_db").getProtocolType()).thenReturn(new
 MockedDatabaseType());
         metaDataManagerPersistService.alterRuleConfiguration(new 
ShardingSphereDatabase("foo_db", new MockedDatabaseType(), mock(), mock(), 
Collections.emptyList()), ruleConfig);
@@ -157,14 +156,14 @@ class ClusterMetaDataManagerPersistServiceTest {
     }
     
     @Test
-    void assertRemoveNullRuleConfigurationItem() throws SQLException {
+    void assertRemoveNullRuleConfigurationItem() {
         metaDataManagerPersistService.removeRuleConfigurationItem(new 
ShardingSphereDatabase("foo_db", mock(), mock(), mock(), 
Collections.emptyList()), null);
         verify(metaDataPersistFacade.getDatabaseRuleService(), 
times(0)).delete(eq("foo_db"), anyCollection());
     }
     
     @Test
     @Disabled
-    void assertRemoveRuleConfigurationItem() throws SQLException {
+    void assertRemoveRuleConfigurationItem() {
         RuleConfiguration ruleConfig = new SingleRuleConfiguration();
         metaDataManagerPersistService.removeRuleConfigurationItem(new 
ShardingSphereDatabase("foo_db", mock(), mock(), mock(), 
Collections.emptyList()), ruleConfig);
         
verify(metaDataPersistFacade.getDatabaseRuleService()).delete("foo_db", 
Collections.singleton(ruleConfig));