This is an automated email from the ASF dual-hosted git repository.
chengzhang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new ff380c11300 Remove useless SQLFederationStatistic in sql federation
(#35342)
ff380c11300 is described below
commit ff380c11300da74afb6654b9407ab2dc44ef5e8e
Author: Zhengqiang Duan <[email protected]>
AuthorDate: Thu May 8 10:15:39 2025 +0800
Remove useless SQLFederationStatistic in sql federation (#35342)
---
.../metadata/schema/SQLFederationSchema.java | 4 +-
.../metadata/schema/SQLFederationTable.java | 9 ----
.../statistic/SQLFederationStatistic.java | 48 ----------------------
3 files changed, 1 insertion(+), 60 deletions(-)
diff --git
a/kernel/sql-federation/optimizer/src/main/java/org/apache/shardingsphere/sqlfederation/optimizer/metadata/schema/SQLFederationSchema.java
b/kernel/sql-federation/optimizer/src/main/java/org/apache/shardingsphere/sqlfederation/optimizer/metadata/schema/SQLFederationSchema.java
index 73e1f141ef3..853bc8f475a 100644
---
a/kernel/sql-federation/optimizer/src/main/java/org/apache/shardingsphere/sqlfederation/optimizer/metadata/schema/SQLFederationSchema.java
+++
b/kernel/sql-federation/optimizer/src/main/java/org/apache/shardingsphere/sqlfederation/optimizer/metadata/schema/SQLFederationSchema.java
@@ -30,7 +30,6 @@ import
org.apache.shardingsphere.infra.metadata.database.schema.model.ShardingSp
import
org.apache.shardingsphere.infra.metadata.database.schema.model.ShardingSphereTable;
import
org.apache.shardingsphere.infra.metadata.database.schema.model.ShardingSphereView;
import
org.apache.shardingsphere.sqlfederation.optimizer.metadata.util.SQLFederationDataTypeUtils;
-import
org.apache.shardingsphere.sqlfederation.optimizer.statistic.SQLFederationStatistic;
import java.util.Collections;
import java.util.Map;
@@ -56,8 +55,7 @@ public final class SQLFederationSchema extends AbstractSchema
{
if (schema.containsView(each.getName())) {
result.put(each.getName(), getViewTable(schema, each,
protocolType, javaTypeFactory));
} else {
- // TODO implement table statistic logic after using custom
operators
- result.put(each.getName(), new SQLFederationTable(each, new
SQLFederationStatistic(), protocolType));
+ result.put(each.getName(), new SQLFederationTable(each,
protocolType));
}
}
return result;
diff --git
a/kernel/sql-federation/optimizer/src/main/java/org/apache/shardingsphere/sqlfederation/optimizer/metadata/schema/SQLFederationTable.java
b/kernel/sql-federation/optimizer/src/main/java/org/apache/shardingsphere/sqlfederation/optimizer/metadata/schema/SQLFederationTable.java
index 20f84cd324f..e66e7190d68 100644
---
a/kernel/sql-federation/optimizer/src/main/java/org/apache/shardingsphere/sqlfederation/optimizer/metadata/schema/SQLFederationTable.java
+++
b/kernel/sql-federation/optimizer/src/main/java/org/apache/shardingsphere/sqlfederation/optimizer/metadata/schema/SQLFederationTable.java
@@ -41,7 +41,6 @@ import org.apache.calcite.rex.RexNode;
import org.apache.calcite.schema.ModifiableTable;
import org.apache.calcite.schema.SchemaPlus;
import org.apache.calcite.schema.Schemas;
-import org.apache.calcite.schema.Statistic;
import org.apache.calcite.schema.TranslatableTable;
import org.apache.calcite.schema.impl.AbstractTable;
import org.apache.shardingsphere.infra.database.core.type.DatabaseType;
@@ -51,7 +50,6 @@ import
org.apache.shardingsphere.sqlfederation.optimizer.metadata.schema.table.E
import
org.apache.shardingsphere.sqlfederation.optimizer.metadata.schema.table.ScanExecutor;
import
org.apache.shardingsphere.sqlfederation.optimizer.metadata.schema.table.ScanExecutorContext;
import
org.apache.shardingsphere.sqlfederation.optimizer.metadata.util.SQLFederationDataTypeUtils;
-import
org.apache.shardingsphere.sqlfederation.optimizer.statistic.SQLFederationStatistic;
import java.lang.reflect.Type;
import java.util.Collection;
@@ -68,8 +66,6 @@ public final class SQLFederationTable extends AbstractTable
implements Modifiabl
private final ShardingSphereTable table;
- private final SQLFederationStatistic statistic;
-
private final DatabaseType protocolType;
@Override
@@ -127,11 +123,6 @@ public final class SQLFederationTable extends
AbstractTable implements Modifiabl
return "SQLFederationTable";
}
- @Override
- public Statistic getStatistic() {
- return statistic;
- }
-
@Override
public Collection<Object[]> getModifiableCollection() {
throw new UnsupportedOperationException();
diff --git
a/kernel/sql-federation/optimizer/src/main/java/org/apache/shardingsphere/sqlfederation/optimizer/statistic/SQLFederationStatistic.java
b/kernel/sql-federation/optimizer/src/main/java/org/apache/shardingsphere/sqlfederation/optimizer/statistic/SQLFederationStatistic.java
deleted file mode 100644
index ca8d57b53c3..00000000000
---
a/kernel/sql-federation/optimizer/src/main/java/org/apache/shardingsphere/sqlfederation/optimizer/statistic/SQLFederationStatistic.java
+++ /dev/null
@@ -1,48 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.shardingsphere.sqlfederation.optimizer.statistic;
-
-import org.apache.calcite.rel.RelCollation;
-import org.apache.calcite.rel.RelDistribution;
-import org.apache.calcite.rel.RelDistributionTraitDef;
-import org.apache.calcite.rel.RelReferentialConstraint;
-import org.apache.calcite.schema.Statistic;
-
-import java.util.ArrayList;
-import java.util.List;
-
-/**
- * SQL federation statistic.
- */
-public final class SQLFederationStatistic implements Statistic {
-
- @Override
- public List<RelReferentialConstraint> getReferentialConstraints() {
- return new ArrayList<>();
- }
-
- @Override
- public List<RelCollation> getCollations() {
- return new ArrayList<>();
- }
-
- @Override
- public RelDistribution getDistribution() {
- return RelDistributionTraitDef.INSTANCE.getDefault();
- }
-}
